Use modern UI elements and application/event-oriented construction in Projects

Summary:
Ref T2715. This partially modernizes projects.

Precursor to using ApplicationSearch, which is a precursor to using application PHIDs.

Then, some day, we will make projects good.

Test Plan: {F51126}

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T2715

Differential Revision: https://secure.phabricator.com/D6524

src/applications/project/controller/PhabricatorProjectProfileController.php

@@ -34,10 +34,6 @@ final class PhabricatorProjectProfileController
 
     $picture = $profile->loadProfileImageURI();
 
-    $nav_view = $this->buildLocalNavigation($project);
-
-    $this->page = $nav_view->selectFilter($this->page, 'dashboard');
-
     require_celerity_resource('phabricator-profile-css');
 
     $tasks = $this->renderTasksPage($project, $profile);
@@ -51,12 +47,10 @@ final class PhabricatorProjectProfileController
     $query->setViewer($this->getRequest()->getUser());
     $stories = $query->execute();
     $feed = $this->renderStories($stories);
-    $about = $this->renderAboutPage($project, $profile);
     $people = $this->renderPeoplePage($project, $profile);
-    $col1 = hsprintf('%s%s', $about, $people);
 
     $content = id(new AphrontMultiColumnView())
-      ->addColumn($col1)
+      ->addColumn($people)
       ->addColumn($feed)
       ->setFluidLayout(true);
 
@@ -70,97 +64,29 @@ final class PhabricatorProjectProfileController
       ->setSubheader(phutil_utf8_shorten($profile->getBlurb(), 1024))
       ->setImage($picture);
 
-    $action = null;
-    if (!$project->isUserMember($user->getPHID())) {
-      $can_join = PhabricatorPolicyFilter::hasCapability(
-        $user,
-        $project,
-        PhabricatorPolicyCapability::CAN_JOIN);
+    $actions = $this->buildActionListView($project);
+    $properties = $this->buildPropertyListView($project);
 
-      $action = id(new PhabricatorActionView())
-        ->setUser($user)
-        ->setRenderAsForm(true)
-        ->setHref('/project/update/'.$project->getID().'/join/')
-        ->setIcon('new')
-        ->setDisabled(!$can_join)
-        ->setName(pht('Join Project'));
-    } else {
-      $action = id(new PhabricatorActionView())
-        ->setWorkflow(true)
-        ->setHref('/project/update/'.$project->getID().'/leave/')
-        ->setIcon('delete')
-        ->setName(pht('Leave Project...'));
-    }
-
-    $action_list = id(new PhabricatorActionListView())
-      ->setUser($user)
-      ->setObjectURI($request->getRequestURI())
-      ->addAction($action);
-
-    $nav_view->appendChild($header);
-    $nav_view->appendChild($action_list);
-    $nav_view->appendChild($content);
+    $crumbs = $this->buildApplicationCrumbs();
+    $crumbs->addCrumb(
+      id(new PhabricatorCrumbView())
+        ->setName($project->getName()));
 
     return $this->buildApplicationPage(
-      $nav_view,
       array(
-        'title' => pht('%s Project', $project->getName()),
+        $crumbs,
+        $header,
+        $actions,
+        $properties,
+        $content,
+      ),
+      array(
+        'title' => $project->getName(),
         'device' => true,
         'dust' => true,
       ));
   }
 
-  private function renderAboutPage(
-    PhabricatorProject $project,
-    PhabricatorProjectProfile $profile) {
-
-    $viewer = $this->getRequest()->getUser();
-
-    $blurb = $profile->getBlurb();
-    $blurb = phutil_escape_html_newlines($blurb);
-
-    $phids = array($project->getAuthorPHID());
-    $phids = array_unique($phids);
-    $handles = $this->loadViewerHandles($phids);
-
-    $timestamp = phabricator_datetime($project->getDateCreated(), $viewer);
-
-    $about = hsprintf(
-      '<div class="phabricator-profile-info-group profile-wrap-responsive">
-        <h1 class="phabricator-profile-info-header">%s</h1>
-        <div class="phabricator-profile-info-pane">
-          <table class="phabricator-profile-info-table">
-            <tr>
-              <th>%s</th>
-              <td>%s</td>
-            </tr>
-            <tr>
-              <th>%s</th>
-              <td>%s</td>
-            </tr>
-            <tr>
-              <th>PHID</th>
-              <td>%s</td>
-            </tr>
-            <tr>
-              <th>%s</th>
-              <td>%s</td>
-            </tr>
-          </table>
-        </div>
-      </div>',
-      pht('About This Project'),
-      pht('Creator'),
-      $handles[$project->getAuthorPHID()]->renderLink(),
-      pht('Created'),
-      $timestamp,
-      $project->getPHID(),
-      pht('Blurb'),
-      $blurb);
-
-    return $about;
-  }
-
   private function renderPeoplePage(
     PhabricatorProject $project,
     PhabricatorProjectProfile $profile) {
@@ -272,8 +198,79 @@ final class PhabricatorProjectProfileController
     return $content;
   }
 
-  public function buildApplicationMenu() {
-    return $this->buildLocalNavigation($this->project)->getMenu();
+  private function buildActionListView(PhabricatorProject $project) {
+    $request = $this->getRequest();
+    $viewer = $request->getUser();
+
+    $id = $project->getID();
+
+    $view = id(new PhabricatorActionListView())
+      ->setUser($viewer)
+      ->setObject($project)
+      ->setObjectURI($request->getRequestURI());
+
+    $can_edit = PhabricatorPolicyFilter::hasCapability(
+      $viewer,
+      $project,
+      PhabricatorPolicyCapability::CAN_EDIT);
+
+    $view->addAction(
+      id(new PhabricatorActionView())
+        ->setName(pht('Edit Project'))
+        ->setIcon('edit')
+        ->setHref($this->getApplicationURI("edit/{$id}/"))
+        ->setDisabled(!$can_edit)
+        ->setWorkflow(!$can_edit));
+
+    $view->addAction(
+      id(new PhabricatorActionView())
+        ->setName(pht('Edit Members'))
+        ->setIcon('edit')
+        ->setHref($this->getApplicationURI("members/{$id}/"))
+        ->setDisabled(!$can_edit)
+        ->setWorkflow(!$can_edit));
+
+
+    $action = null;
+    if (!$project->isUserMember($viewer->getPHID())) {
+      $can_join = PhabricatorPolicyFilter::hasCapability(
+        $viewer,
+        $project,
+        PhabricatorPolicyCapability::CAN_JOIN);
+
+      $action = id(new PhabricatorActionView())
+        ->setUser($viewer)
+        ->setRenderAsForm(true)
+        ->setHref('/project/update/'.$project->getID().'/join/')
+        ->setIcon('new')
+        ->setDisabled(!$can_join)
+        ->setName(pht('Join Project'));
+    } else {
+      $action = id(new PhabricatorActionView())
+        ->setWorkflow(true)
+        ->setHref('/project/update/'.$project->getID().'/leave/')
+        ->setIcon('delete')
+        ->setName(pht('Leave Project...'));
+    }
+    $view->addAction($action);
+
+    return $view;
   }
 
+  private function buildPropertyListView(PhabricatorProject $project) {
+    $request = $this->getRequest();
+    $viewer = $request->getUser();
+
+    $view = id(new PhabricatorPropertyListView())
+      ->setUser($viewer)
+      ->setObject($project);
+
+    $view->addProperty(
+      pht('Created'),
+      phabricator_datetime($project->getDateCreated(), $viewer));
+
+    return $view;
+  }
+
+
 }