archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon Overseer

Browse Source 
Summary: Ref T13579. This property was removed in D21425, but I missed this usage site. Remove the assignment; this class no longer tracks the subprocess PID directly.

Test Plan: Searched for "->pid", no further hits.

Maniphest Tasks: T13579

Differential Revision: https://secure.phabricator.com/D21452
This commit is contained in:
epriestley
2020-09-04 16:37:23 -07:00
parent 0854425d19
commit 7daaaa8463
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/infrastructure/daemon/PhutilDaemonHandle.php
View File

@@ -356,7 +356,6 @@ final class PhutilDaemonHandle extends Phobject {
posix_kill(-$pgid, SIGTERM); posix_kill(-$pgid, SIGTERM);
sleep($this->getKillDelay()); sleep($this->getKillDelay());
posix_kill(-$pgid, SIGKILL); posix_kill(-$pgid, SIGKILL);
$this->pid = null;
} }
} }
} }