archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix missing EditEngineConfig on indirect pathway through conduit.query

Browse Source 
Summary: Fixes T9772. We now need an EditEngineConfiguration to do interesting things with EditEngine, but this public API wasn't properly making sure we have one.

Test Plan: Called `conduit.query` from web console. Fatal prior to patch; success afterward.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9772

Differential Revision: https://secure.phabricator.com/D14475
This commit is contained in:
epriestley
2015-11-12 10:49:39 -08:00
parent bb9b25a7ba
commit 7e3d8082df
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/applications/transactions/editengine/PhabricatorEditEngine.php
View File

@@ -961,6 +961,11 @@ abstract class PhabricatorEditEngine
} }
public function getAllEditTypes() { public function getAllEditTypes() {
$config = $this->loadEditEngineConfiguration(null);
if (!$config) {
return array();
}
$object = $this->newEditableObject(); $object = $this->newEditableObject();
$fields = $this->buildEditFields($object); $fields = $this->buildEditFields($object);
return $this->getAllEditTypesFromFields($fields); return $this->getAllEditTypesFromFields($fields);