archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Improve puncutation usage

Browse Source 
Summary: Use periods where appropriate.

Test Plan: shipitquick

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11110
This commit is contained in:
Joshua Spence
2015-01-01 15:40:04 +11:00
parent 337b811d8e
commit 7e54ab23b3
4 changed files with 51 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/applications/maniphest/storage/ManiphestTransaction.php
View File

@@ -503,19 +503,19 @@ final class ManiphestTransaction
$removed = array_diff($old, $new); $removed = array_diff($old, $new);
if ($added && !$removed) { if ($added && !$removed) {
return pht( return pht(
'%s attached %d file(s): %s', '%s attached %d file(s): %s.',
$this->renderHandleLink($author_phid), $this->renderHandleLink($author_phid),
count($added), count($added),
$this->renderHandleList($added)); $this->renderHandleList($added));
} else if ($removed && !$added) { } else if ($removed && !$added) {
return pht( return pht(
'%s detached %d file(s): %s', '%s detached %d file(s): %s.',
$this->renderHandleLink($author_phid), $this->renderHandleLink($author_phid),
count($removed), count($removed),
$this->renderHandleList($removed)); $this->renderHandleList($removed));
} else { } else {
return pht( return pht(
'%s changed file(s), attached %d: %s; detached %d: %s', '%s changed file(s), attached %d: %s; detached %d: %s.',
$this->renderHandleLink($author_phid), $this->renderHandleLink($author_phid),
count($added), count($added),
$this->renderHandleList($added), $this->renderHandleList($added),

2
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
View File

@@ -328,7 +328,7 @@ final class PhabricatorProjectTransactionEditor
$type, $type,
pht('Invalid'), pht('Invalid'),
pht( pht(
'%d project hashtag(s) are already used: %s', '%d project hashtag(s) are already used: %s.',
count($used_slug_strs), count($used_slug_strs),
implode(', ', $used_slug_strs)), implode(', ', $used_slug_strs)),
$slug_xaction); $slug_xaction);

12
src/applications/project/storage/PhabricatorProjectTransaction.php
View File

@@ -118,7 +118,7 @@ final class PhabricatorProjectTransaction
if ($add && $rem) { if ($add && $rem) {
return pht( return pht(
'%s changed project hashtag(s), added %d: %s; removed %d: %s', '%s changed project hashtag(s), added %d: %s; removed %d: %s.',
$author_handle, $author_handle,
count($add), count($add),
$this->renderSlugList($add), $this->renderSlugList($add),
@@ -126,13 +126,13 @@ final class PhabricatorProjectTransaction
$this->renderSlugList($rem)); $this->renderSlugList($rem));
} else if ($add) { } else if ($add) {
return pht( return pht(
'%s added %d project hashtag(s): %s', '%s added %d project hashtag(s): %s.',
$author_handle, $author_handle,
count($add), count($add),
$this->renderSlugList($add)); $this->renderSlugList($add));
} else if ($rem) { } else if ($rem) {
return pht( return pht(
'%s removed %d project hashtag(s): %s', '%s removed %d project hashtag(s): %s.',
$author_handle, $author_handle,
count($rem), count($rem),
$this->renderSlugList($rem)); $this->renderSlugList($rem));
@@ -144,7 +144,7 @@ final class PhabricatorProjectTransaction
if ($add && $rem) { if ($add && $rem) {
return pht( return pht(
'%s changed project member(s), added %d: %s; removed %d: %s', '%s changed project member(s), added %d: %s; removed %d: %s.',
$author_handle, $author_handle,
count($add), count($add),
$this->renderHandleList($add), $this->renderHandleList($add),
@@ -157,7 +157,7 @@ final class PhabricatorProjectTransaction
$author_handle); $author_handle);
} else { } else {
return pht( return pht(
'%s added %d project member(s): %s', '%s added %d project member(s): %s.',
$author_handle, $author_handle,
count($add), count($add),
$this->renderHandleList($add)); $this->renderHandleList($add));
@@ -169,7 +169,7 @@ final class PhabricatorProjectTransaction
$author_handle); $author_handle);
} else { } else {
return pht( return pht(
'%s removed %d project member(s): %s', '%s removed %d project member(s): %s.',
$author_handle, $author_handle,
count($rem), count($rem),
$this->renderHandleList($rem)); $this->renderHandleList($rem));

96
src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php
View File

@@ -131,7 +131,7 @@ abstract class PhabricatorBaseEnglishTranslation
), ),
'%s edited member(s), added %d: %s; removed %d: %s.' => '%s edited member(s), added %d: %s; removed %d: %s.' =>
'%s edited members, added: %3$s; removed: %5$s', '%s edited members, added: %3$s; removed: %5$s.',
'%s added %d member(s): %s.' => array( '%s added %d member(s): %s.' => array(
array( array(
@@ -148,7 +148,7 @@ abstract class PhabricatorBaseEnglishTranslation
), ),
'%s edited project(s), added %d: %s; removed %d: %s.' => '%s edited project(s), added %d: %s; removed %d: %s.' =>
'%s edited projects, added: %3$s; removed: %5$s', '%s edited projects, added: %3$s; removed: %5$s.',
'%s added %d project(s): %s.' => array( '%s added %d project(s): %s.' => array(
array( array(
@@ -249,19 +249,19 @@ abstract class PhabricatorBaseEnglishTranslation
), ),
'%s edited blocking task(s), added %s: %s; removed %s: %s.' => '%s edited blocking task(s), added %s: %s; removed %s: %s.' =>
'%s edited blocking tasks, added: %3$s; removed: %5$s', '%s edited blocking tasks, added: %3$s; removed: %5$s.',
'%s edited blocking task(s) for %s, added %s: %s; removed %s: %s.' => '%s edited blocking task(s) for %s, added %s: %s; removed %s: %s.' =>
'%s edited blocking tasks for %s, added: %4$s; removed: %6$s', '%s edited blocking tasks for %s, added: %4$s; removed: %6$s.',
'%s edited blocked task(s), added %s: %s; removed %s: %s.' => '%s edited blocked task(s), added %s: %s; removed %s: %s.' =>
'%s edited blocked tasks, added: %3$s; removed: %5$s', '%s edited blocked tasks, added: %3$s; removed: %5$s.',
'%s edited blocked task(s) for %s, added %s: %s; removed %s: %s.' => '%s edited blocked task(s) for %s, added %s: %s; removed %s: %s.' =>
'%s edited blocked tasks for %s, added: %4$s; removed: %6$s', '%s edited blocked tasks for %s, added: %4$s; removed: %6$s.',
'%s edited answer(s), added %s: %s; removed %d: %s.' => '%s edited answer(s), added %s: %s; removed %d: %s.' =>
'%s edited answers, added: %3$s; removed: %5$s', '%s edited answers, added: %3$s; removed: %5$s.',
'%s added %s answer(s): %s.' => array( '%s added %s answer(s): %s.' => array(
array( array(
@@ -278,7 +278,7 @@ abstract class PhabricatorBaseEnglishTranslation
), ),
'%s edited question(s), added %s: %s; removed %s: %s.' => '%s edited question(s), added %s: %s; removed %s: %s.' =>
'%s edited questions, added: %3$s; removed: %5$s', '%s edited questions, added: %3$s; removed: %5$s.',
'%s added %s question(s): %s.' => array( '%s added %s question(s): %s.' => array(
array( array(
@@ -295,7 +295,7 @@ abstract class PhabricatorBaseEnglishTranslation
), ),
'%s edited mock(s), added %d: %s; removed %d: %s.' => '%s edited mock(s), added %d: %s; removed %d: %s.' =>
'%s edited mocks, added: %3$s; removed: %5$s', '%s edited mocks, added: %3$s; removed: %5$s.',
'%s added %d mock(s): %s.' => array( '%s added %d mock(s): %s.' => array(
array( array(
@@ -326,7 +326,7 @@ abstract class PhabricatorBaseEnglishTranslation
), ),
'%s edited file(s), added %d: %s; removed %d: %s.' => '%s edited file(s), added %d: %s; removed %d: %s.' =>
'%s edited files, added: %3$s; removed: %5$s', '%s edited files, added: %3$s; removed: %5$s.',
'%s added %d file(s): %s.' => array( '%s added %d file(s): %s.' => array(
array( array(
@@ -343,7 +343,7 @@ abstract class PhabricatorBaseEnglishTranslation
), ),
'%s edited contributor(s), added %d: %s; removed %d: %s.' => '%s edited contributor(s), added %d: %s; removed %d: %s.' =>
'%s edited contributors, added: %3$s; removed: %5$s', '%s edited contributors, added: %3$s; removed: %5$s.',
'%s added %d contributor(s): %s.' => array( '%s added %d contributor(s): %s.' => array(
array( array(
@@ -360,7 +360,7 @@ abstract class PhabricatorBaseEnglishTranslation
), ),
'%s edited reviewer(s), added %s: %s; removed %s: %s.' => '%s edited reviewer(s), added %s: %s; removed %s: %s.' =>
'%s edited reviewers, added: %4$s; removed: %6$s', '%s edited reviewers, added: %4$s; removed: %6$s.',
'%s added %s reviewer(s): %s.' => array( '%s added %s reviewer(s): %s.' => array(
array( array(
@@ -377,7 +377,7 @@ abstract class PhabricatorBaseEnglishTranslation
), ),
'%s edited object(s), added %d: %s; removed %d: %s.' => '%s edited object(s), added %d: %s; removed %d: %s.' =>
'%s edited objects, added: %3$s; removed: %5$s', '%s edited objects, added: %3$s; removed: %5$s.',
'%s added %d object(s): %s.' => array( '%s added %d object(s): %s.' => array(
array( array(
@@ -399,7 +399,7 @@ abstract class PhabricatorBaseEnglishTranslation
), ),
'%s edited subscriber(s), added %d: %s; removed %d: %s.' => '%s edited subscriber(s), added %d: %s; removed %d: %s.' =>
'%s edited subscribers, added: %3$s; removed: %5$s', '%s edited subscribers, added: %3$s; removed: %5$s.',
'%s added %d subscriber(s): %s.' => array( '%s added %d subscriber(s): %s.' => array(
array( array(
@@ -416,7 +416,7 @@ abstract class PhabricatorBaseEnglishTranslation
), ),
'%s edited participant(s), added %d: %s; removed %d: %s.' => '%s edited participant(s), added %d: %s; removed %d: %s.' =>
'%s edited participants, added: %3$s; removed: %5$s', '%s edited participants, added: %3$s; removed: %5$s.',
'%s added %d participant(s): %s.' => array( '%s added %d participant(s): %s.' => array(
array( array(
@@ -551,36 +551,22 @@ abstract class PhabricatorBaseEnglishTranslation
'%s Commits', '%s Commits',
), ),
'%s added %d project(s): %s' => array( '%s attached %d file(s): %s.' => array(
array( array(
'%s added a project: %3$s', '%s attached a file: %3$s.',
'%s added projects: %3$s', '%s attached files: %3$s.',
), ),
), ),
'%s removed %d project(s): %s' => array( '%s detached %d file(s): %s.' => array(
array( array(
'%s removed a project: %3$s', '%s detached a file: %3$s.',
'%s removed projects: %3$s', '%s detached files: %3$s.',
), ),
), ),
'%s attached %d file(s): %s' => array( '%s changed file(s), attached %d: %s; detached %d: %s.' =>
array( '%s changed files, attached: %3$s; detached: %5$s.',
'%s attached a file: %3$s',
'%s attached files: %3$s',
),
),
'%s detached %d file(s): %s' => array(
array(
'%s detached a file: %3$s',
'%s detached files: %3$s',
),
),
'%s changed file(s), attached %d: %s; detached %d: %s' =>
'%s changed files, attached: %3$s; detached: %5$s',
'%s added %s dependencie(s): %s.' => array( '%s added %s dependencie(s): %s.' => array(
@@ -628,42 +614,42 @@ abstract class PhabricatorBaseEnglishTranslation
'%s edited commit(s), added %s: %s; removed %s: %s.' => '%s edited commit(s), added %s: %s; removed %s: %s.' =>
'%s edited commits, added %3$s; removed %5$s.', '%s edited commits, added %3$s; removed %5$s.',
'%s changed project member(s), added %d: %s; removed %d: %s' => '%s changed project member(s), added %d: %s; removed %d: %s.' =>
'%s changed project members, added %3$s; removed %5$s', '%s changed project members, added %3$s; removed %5$s.',
'%s added %d project member(s): %s' => array( '%s added %d project member(s): %s.' => array(
array( array(
'%s added a member: %3$s', '%s added a member: %3$s.',
'%s added members: %3$s', '%s added members: %3$s.',
), ),
), ),
'%s removed %d project member(s): %s' => array( '%s removed %d project member(s): %s.' => array(
array( array(
'%s removed a member: %3$s', '%s removed a member: %3$s.',
'%s removed members: %3$s', '%s removed members: %3$s.',
), ),
), ),
'%d project hashtag(s) are already used: %s' => array( '%d project hashtag(s) are already used: %s.' => array(
'Project hashtag %2$s is already used.', 'Project hashtag %2$s is already used.',
'%d project hashtags are already used: %2$s', '%d project hashtags are already used: %2$s.',
), ),
'%s changed project hashtag(s), added %d: %s; removed %d: %s' => '%s changed project hashtag(s), added %d: %s; removed %d: %s.' =>
'%s changed project hashtags, added %3$s; removed %5$s', '%s changed project hashtags, added %3$s; removed %5$s.',
'%s added %d project hashtag(s): %s' => array( '%s added %d project hashtag(s): %s.' => array(
array( array(
'%s added a hashtag: %3$s', '%s added a hashtag: %3$s.',
'%s added hashtags: %3$s', '%s added hashtags: %3$s.',
), ),
), ),
'%s removed %d project hashtag(s): %s' => array( '%s removed %d project hashtag(s): %s.' => array(
array( array(
'%s removed a hashtag: %3$s', '%s removed a hashtag: %3$s.',
'%s removed hashtags: %3$s', '%s removed hashtags: %3$s.',
), ),
), ),