Update Create Diff page for new Edit UI
Summary: Create a diff page, new UI Test Plan: Create a diff from page Reviewers: epriestley Reviewed By: epriestley Spies: Korvin Differential Revision: https://secure.phabricator.com/D18529
This commit is contained in:
		| @@ -182,10 +182,10 @@ final class DifferentialDiffCreateController extends DifferentialController { | |||||||
|           ->setValue($button)); |           ->setValue($button)); | ||||||
|  |  | ||||||
|     $form_box = id(new PHUIObjectBoxView()) |     $form_box = id(new PHUIObjectBoxView()) | ||||||
|       ->setHeaderText(pht('Diff')) |       ->setHeaderText($title) | ||||||
|       ->setValidationException($validation_exception) |       ->setValidationException($validation_exception) | ||||||
|       ->setForm($form) |       ->setForm($form) | ||||||
|       ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) |       ->setBackground(PHUIObjectBoxView::WHITE_CONFIG) | ||||||
|       ->setFormErrors($errors); |       ->setFormErrors($errors); | ||||||
|  |  | ||||||
|     $crumbs = $this->buildApplicationCrumbs(); |     $crumbs = $this->buildApplicationCrumbs(); | ||||||
| @@ -197,15 +197,10 @@ final class DifferentialDiffCreateController extends DifferentialController { | |||||||
|     $crumbs->addTextCrumb($title); |     $crumbs->addTextCrumb($title); | ||||||
|     $crumbs->setBorder(true); |     $crumbs->setBorder(true); | ||||||
|  |  | ||||||
|     $header = id(new PHUIHeaderView()) |  | ||||||
|       ->setHeader($title) |  | ||||||
|       ->setHeaderIcon($header_icon); |  | ||||||
|  |  | ||||||
|     $view = id(new PHUITwoColumnView()) |     $view = id(new PHUITwoColumnView()) | ||||||
|       ->setHeader($header) |  | ||||||
|       ->setFooter(array( |       ->setFooter(array( | ||||||
|         $info_view, |  | ||||||
|         $form_box, |         $form_box, | ||||||
|  |         $info_view, | ||||||
|       )); |       )); | ||||||
|  |  | ||||||
|     return $this->newPage() |     return $this->newPage() | ||||||
|   | |||||||
| @@ -59,6 +59,7 @@ final class PHUIInfoView extends AphrontTagView { | |||||||
|     } else { |     } else { | ||||||
|       $icon = id(new PHUIIconView()) |       $icon = id(new PHUIIconView()) | ||||||
|         ->setIcon($icon); |         ->setIcon($icon); | ||||||
|  |       $this->icon = $icon; | ||||||
|     } |     } | ||||||
|  |  | ||||||
|     return $this; |     return $this; | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user
	 Chad Little
					Chad Little