Allows a button type for menus, used in Conpherence

Summary: This adds a new menu item, TYPEBUTTON, for use in Conpherence and maybe others over time. Note I need to add icon support, but I'll make them later tonight. I also changed the front facing names to 'Conversations' which is way more natural. Basically, Pholio has Mocks, Differential has Diffs, Conpherence has Conversations.

Test Plan: Tested Conpherence on mobile and desktop.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2430

Differential Revision: https://secure.phabricator.com/D4691
This commit is contained in:
Chad Little
2013-01-29 10:20:17 -08:00
parent 5017c80b31
commit 830c2410eb
7 changed files with 92 additions and 49 deletions

View File

@@ -107,9 +107,9 @@ abstract class ConpherenceController extends PhabricatorController {
$nav->addClass('conpherence-menu');
$nav->setMenuID('conpherence-menu');
$nav->addFilter(
$nav->addButton(
'new',
pht('New Conpherence'),
pht('New Conversation'),
$this->getApplicationURI('new/')
);
$nav->addLabel(pht('Unread'));
@@ -171,7 +171,7 @@ abstract class ConpherenceController extends PhabricatorController {
array(
'class' => 'no-conpherences-menu-item'
),
pht('No more conpherences.')
pht('No more conversations.')
);
}
@@ -185,7 +185,7 @@ abstract class ConpherenceController extends PhabricatorController {
$crumbs
->addAction(
id(new PhabricatorMenuItemView())
->setName(pht('New Conpherence'))
->setName(pht('New Conversation'))
->setHref($this->getApplicationURI('new/'))
->setIcon('create')
)