Uninstall Conduit calls when uninstalling applications

Summary: Fixes T2698. When applications are installed, their Conduit calls should drop out. This will also let us land Releeph without exposing Conduit calls.

Test Plan:
  - Viewed Conduit console; uninstalled some applications and verified their calls dropped out.
  - Tried to make an uninstalled call; got an appropriate error.

Reviewers: edward, btrahan

Reviewed By: edward

CC: aran

Maniphest Tasks: T2698

Differential Revision: https://secure.phabricator.com/D5302
This commit is contained in:
epriestley
2013-03-13 07:09:05 -07:00
parent 1341c8a6c1
commit 855e085c6f
38 changed files with 215 additions and 43 deletions

View File

@@ -86,6 +86,12 @@ abstract class PhabricatorConduitController extends PhabricatorController {
$group_name = head(explode('.', $method_name));
$method_object = newv($method_class, array());
$application = $method_object->getApplication();
if ($application && !$application->isInstalled()) {
continue;
}
$status = $method_object->getMethodStatus();
$key = sprintf(