cowboy commit -- fixing fatal I introduced from D4174
Summary: we don't always have a diff so instead set an explicit title in the controller. Test Plan: no more fatals. grepped carefully for every call site and tested them all
This commit is contained in:
@@ -14,13 +14,16 @@ final class DiffusionChangeController extends DiffusionController {
|
||||
// TODO: Refine this.
|
||||
return new Aphront404Response();
|
||||
}
|
||||
|
||||
$callsign = $drequest->getRepository()->getCallsign();
|
||||
|
||||
$repository = $drequest->getRepository();
|
||||
$callsign = $repository->getCallsign();
|
||||
$commit = $drequest->getRawCommit();
|
||||
$changesets = array(
|
||||
0 => $changeset,
|
||||
);
|
||||
|
||||
$changeset_view = new DifferentialChangesetListView();
|
||||
$changeset_view->setTitle(DiffusionView::nameCommit($repository, $commit));
|
||||
$changeset_view->setChangesets($changesets);
|
||||
$changeset_view->setVisibleChangesets($changesets);
|
||||
$changeset_view->setRenderingReferences(
|
||||
|
||||
@@ -257,7 +257,12 @@ final class DiffusionCommitController extends DiffusionController {
|
||||
}
|
||||
}
|
||||
|
||||
$change_list_title = DiffusionView::nameCommit(
|
||||
$repository,
|
||||
$commit->getCommitIdentifier()
|
||||
);
|
||||
$change_list = new DifferentialChangesetListView();
|
||||
$change_list->setTitle($change_list_title);
|
||||
$change_list->setChangesets($changesets);
|
||||
$change_list->setVisibleChangesets($visible_changesets);
|
||||
$change_list->setRenderingReferences($references);
|
||||
|
||||
Reference in New Issue
Block a user