Rename PhabricatorApplication subclasses
Summary: Ref T5655. Some discussion in D9839. Generally speaking, `Phabricator{$name}Application` is clearer than `PhabricatorApplication{$name}`.
Test Plan:
# Pinned and uninstalled some applications.
# Applied patch and performed migrations.
# Verified that the pinned applications were still pinned and that the uninstalled applications were still uninstalled.
# Performed a sanity check on the database contents.
Reviewers: btrahan, epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: hach-que, epriestley, Korvin
Maniphest Tasks: T5655
Differential Revision: https://secure.phabricator.com/D9982
This commit is contained in:
@@ -8,9 +8,7 @@
|
||||
class AphrontDefaultApplicationConfiguration
|
||||
extends AphrontApplicationConfiguration {
|
||||
|
||||
public function __construct() {
|
||||
|
||||
}
|
||||
public function __construct() {}
|
||||
|
||||
public function getApplicationName() {
|
||||
return 'aphront-default';
|
||||
@@ -172,7 +170,6 @@ class AphrontDefaultApplicationConfiguration
|
||||
}
|
||||
|
||||
if ($ex instanceof PhabricatorPolicyException) {
|
||||
|
||||
if (!$user->isLoggedIn()) {
|
||||
// If the user isn't logged in, just give them a login form. This is
|
||||
// probably a generally more useful response than a policy dialog that
|
||||
@@ -182,7 +179,7 @@ class AphrontDefaultApplicationConfiguration
|
||||
// the thing you are trying to look at".
|
||||
$login_controller = new PhabricatorAuthStartController($request);
|
||||
|
||||
$auth_app_class = 'PhabricatorApplicationAuth';
|
||||
$auth_app_class = 'PhabricatorAuthApplication';
|
||||
$auth_app = PhabricatorApplication::getByClass($auth_app_class);
|
||||
$login_controller->setCurrentApplication($auth_app);
|
||||
|
||||
@@ -247,7 +244,6 @@ class AphrontDefaultApplicationConfiguration
|
||||
return $response;
|
||||
}
|
||||
|
||||
|
||||
// Always log the unhandled exception.
|
||||
phlog($ex);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user