Rename PhabricatorApplication subclasses
Summary: Ref T5655. Some discussion in D9839. Generally speaking, `Phabricator{$name}Application` is clearer than `PhabricatorApplication{$name}`.
Test Plan:
# Pinned and uninstalled some applications.
# Applied patch and performed migrations.
# Verified that the pinned applications were still pinned and that the uninstalled applications were still uninstalled.
# Performed a sanity check on the database contents.
Reviewers: btrahan, epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: hach-que, epriestley, Korvin
Maniphest Tasks: T5655
Differential Revision: https://secure.phabricator.com/D9982
This commit is contained in:
@@ -37,11 +37,9 @@ abstract class DiffusionBrowseController extends DiffusionController {
|
||||
break;
|
||||
}
|
||||
|
||||
|
||||
$filter = new AphrontListFilterView();
|
||||
$filter->appendChild($forms);
|
||||
|
||||
|
||||
if ($collapsed) {
|
||||
$filter->setCollapsed(
|
||||
pht('Show Search'),
|
||||
@@ -112,7 +110,7 @@ abstract class DiffusionBrowseController extends DiffusionController {
|
||||
// TODO: Ideally, this should live in Owners and be event-triggered, but
|
||||
// there's no reasonable object for it to react to right now.
|
||||
|
||||
$owners = 'PhabricatorApplicationOwners';
|
||||
$owners = 'PhabricatorOwnersApplication';
|
||||
if (PhabricatorApplication::isClassInstalled($owners)) {
|
||||
$owners_uri = id(new PhutilURI('/owners/view/search/'))
|
||||
->setQueryParams(
|
||||
@@ -220,7 +218,6 @@ abstract class DiffusionBrowseController extends DiffusionController {
|
||||
return id(new PHUIObjectBoxView())
|
||||
->setHeaderText(pht('Pending Differential Revisions'))
|
||||
->appendChild($view);
|
||||
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user