Mobile Crumbs.

Summary: Not for full review. This makes crumbs appear consistently in mobile. It helps give a quick link to the apps home, the page title currently on, and action icons for the object. It will take additional clean-up to make this consistent across apps. Passing for early review from a UEX perspective. I actually really like it and think onces it's everywhere, helps mobile feel complete.

Test Plan: Testing in iOS and Simulator.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2796

Differential Revision: https://secure.phabricator.com/D5446
This commit is contained in:
Chad Little
2013-03-26 13:15:15 -07:00
parent 6115756e9d
commit 8a0fccf97a
14 changed files with 129 additions and 79 deletions

View File

@@ -65,13 +65,24 @@ final class DifferentialDiffCreateController extends DifferentialController {
$panel = new AphrontPanelView();
$panel->setHeader(pht('Create New Diff'));
$panel->setNoBackground();
$panel->appendChild($form);
$panel->setWidth(AphrontPanelView::WIDTH_FORM);
return $this->buildStandardPageResponse(
$panel,
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName(pht('Create Diff'))
->setHref('/differential/diff/create/'));
return $this->buildApplicationPage(
array(
$crumbs,
$panel
),
array(
'title' => pht('Create Diff'),
'device' => true,
));
}