Mobile Crumbs.

Summary: Not for full review. This makes crumbs appear consistently in mobile. It helps give a quick link to the apps home, the page title currently on, and action icons for the object. It will take additional clean-up to make this consistent across apps. Passing for early review from a UEX perspective. I actually really like it and think onces it's everywhere, helps mobile feel complete.

Test Plan: Testing in iOS and Simulator.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2796

Differential Revision: https://secure.phabricator.com/D5446

src/applications/files/controller/PhabricatorFileListController.php

@@ -48,12 +48,8 @@ final class PhabricatorFileListController extends PhabricatorFileController {
     $side_nav = $this->buildSideNavView();
     $side_nav->selectFilter($this->getFilter());
 
-    $header_view = id(new PhabricatorHeaderView())
-      ->setHeader($header);
-
     $side_nav->appendChild(
       array(
-        $header_view,
         $file_list,
         $pager,
         new PhabricatorGlobalUploadTargetView(),
@@ -72,6 +68,7 @@ final class PhabricatorFileListController extends PhabricatorFileController {
       array(
         'title' => 'Files',
         'device' => true,
+        'dust' => true,
       ));
   }
 

src/applications/files/controller/PhabricatorFileUploadController.php

@@ -39,7 +39,6 @@ final class PhabricatorFileUploadController extends PhabricatorFileController {
           'desktop onto this page or the Phabricator home page.')));
 
     $form = id(new AphrontFormView())
-      ->setFlexible(true)
       ->setUser($user)
       ->setEncType('multipart/form-data')
       ->appendChild(
@@ -68,9 +67,6 @@ final class PhabricatorFileUploadController extends PhabricatorFileController {
 
     $title = pht('Upload File');
 
-    $header = id(new PhabricatorHeaderView())
-      ->setHeader($title);
-
     if ($errors) {
       $errors = id(new AphrontErrorView())
         ->setTitle(pht('Form Errors'))
@@ -80,12 +76,17 @@ final class PhabricatorFileUploadController extends PhabricatorFileController {
     $global_upload = id(new PhabricatorGlobalUploadTargetView())
       ->setShowIfSupportedID($support_id);
 
+    $panel = new AphrontPanelView();
+    $panel->setHeader(pht('New File Upload'));
+    $panel->setNoBackground();
+    $panel->appendChild($form);
+    $panel->setWidth(AphrontPanelView::WIDTH_FORM);
+
     return $this->buildApplicationPage(
       array(
         $crumbs,
-        $header,
         $errors,
-        $form,
+        $panel,
         $global_upload,
       ),
       array(