Mobile Crumbs.
Summary: Not for full review. This makes crumbs appear consistently in mobile. It helps give a quick link to the apps home, the page title currently on, and action icons for the object. It will take additional clean-up to make this consistent across apps. Passing for early review from a UEX perspective. I actually really like it and think onces it's everywhere, helps mobile feel complete. Test Plan: Testing in iOS and Simulator. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2796 Differential Revision: https://secure.phabricator.com/D5446
This commit is contained in:
@@ -152,7 +152,6 @@ final class PhabricatorMacroEditController
|
||||
}
|
||||
|
||||
$form = new AphrontFormView();
|
||||
$form->setFlexible(true);
|
||||
$form->addHiddenInput('name_form', 1);
|
||||
$form->setUser($request->getUser());
|
||||
|
||||
@@ -237,10 +236,6 @@ final class PhabricatorMacroEditController
|
||||
->setHref($request->getRequestURI())
|
||||
->setName($crumb));
|
||||
|
||||
$header = id(new PhabricatorHeaderView())
|
||||
->setHeader($title);
|
||||
|
||||
|
||||
$upload = null;
|
||||
if ($macro->getID()) {
|
||||
$upload_header = id(new PhabricatorHeaderView())
|
||||
@@ -272,16 +267,22 @@ final class PhabricatorMacroEditController
|
||||
$upload = array($upload_header, $upload_form);
|
||||
}
|
||||
|
||||
$panel = new AphrontPanelView();
|
||||
$panel->setHeader(pht('Create New Macro'));
|
||||
$panel->setNoBackground();
|
||||
$panel->appendChild($form);
|
||||
$panel->setWidth(AphrontPanelView::WIDTH_FORM);
|
||||
|
||||
return $this->buildApplicationPage(
|
||||
array(
|
||||
$crumbs,
|
||||
$header,
|
||||
$error_view,
|
||||
$form,
|
||||
$panel,
|
||||
$upload,
|
||||
),
|
||||
array(
|
||||
'title' => $title,
|
||||
'device' => true,
|
||||
));
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user