archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Normalize casing on property boxes

Browse Source 
Summary: Going to render these all normal case instead of all caps, and bump up the font size. Should be more consistent. Yellow if you green anything orange.

Test Plan: grep, lint

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15645
This commit is contained in:
Chad Little
2016-04-06 15:20:53 -07:00
parent 439821c7b2
commit 8aad862cd4
33 changed files with 44 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/applications/diffusion/controller/DiffusionBrowseController.php
View File

@@ -310,7 +310,7 @@ final class DiffusionBrowseController extends DiffusionController {
));
if ($properties) {
$view->addPropertySection(pht('DETAILS'), $properties);
$view->addPropertySection(pht('Details'), $properties);
}
$title = array($basename, $repository->getDisplayName());
@@ -413,7 +413,7 @@ final class DiffusionBrowseController extends DiffusionController {
));
if ($details) {
$view->addPropertySection(pht('DETAILS'), $details);
$view->addPropertySection(pht('Details'), $details);
}
return $this->newPage()
@@ -1409,7 +1409,7 @@ final class DiffusionBrowseController extends DiffusionController {
$file = $this->renderFileButton($file_uri);
$header = id(new PHUIHeaderView())
->setHeader(pht('DETAILS'))
->setHeader(pht('Details'))
->addActionLink($file);
$box = id(new PHUIObjectBoxView())
@@ -1426,7 +1426,7 @@ final class DiffusionBrowseController extends DiffusionController {
->appendChild($message);
$header = id(new PHUIHeaderView())
->setHeader(pht('DETAILS'));
->setHeader(pht('Details'));
$box = id(new PHUIObjectBoxView())
->setHeader($header)

4
src/applications/diffusion/controller/DiffusionCommitController.php
View File

@@ -355,8 +355,8 @@ final class DiffusionCommitController extends DiffusionController {
$change_list,
$add_comment,
))
->addPropertySection(pht('DESCRIPTION'), $detail_list)
->addPropertySection(pht('DETAILS'), $details)
->addPropertySection(pht('Description'), $detail_list)
->addPropertySection(pht('Details'), $details)
->setCurtain($curtain);
$page = $this->newPage()

4
src/applications/diffusion/controller/DiffusionRepositoryController.php
View File

@@ -288,7 +288,7 @@ final class DiffusionRepositoryController extends DiffusionController {
$description = new PHUIRemarkupView($viewer, $description);
$view->addTextContent($description);
return id(new PHUIObjectBoxView())
->setHeaderText(pht('DESCRIPTION'))
->setHeaderText(pht('Description'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->appendChild($view);
}
@@ -354,7 +354,7 @@ final class DiffusionRepositoryController extends DiffusionController {
}
$box = id(new PHUIObjectBoxView())
->setHeaderText(pht('DETAILS'))
->setHeaderText(pht('Details'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->appendChild($view);