archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Normalize casing on property boxes

Browse Source 
Summary: Going to render these all normal case instead of all caps, and bump up the font size. Should be more consistent. Yellow if you green anything orange.

Test Plan: grep, lint

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15645
This commit is contained in:
Chad Little
2016-04-06 15:20:53 -07:00
parent 439821c7b2
commit 8aad862cd4
33 changed files with 44 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/almanac/controller/AlmanacBindingViewController.php
View File

@@ -68,7 +68,7 @@ final class AlmanacBindingViewController
$this->buildAlmanacPropertiesTable($binding), $this->buildAlmanacPropertiesTable($binding),
$timeline, $timeline,
)) ))
->addPropertySection(pht('DETAILS'), $details); ->addPropertySection(pht('Details'), $details);
return $this->newPage() return $this->newPage()
->setTitle($title) ->setTitle($title)

2
src/applications/almanac/controller/AlmanacController.php
View File

@@ -158,7 +158,7 @@ abstract class AlmanacController
->setIcon('fa-plus'); ->setIcon('fa-plus');
$header = id(new PHUIHeaderView()) $header = id(new PHUIHeaderView())
->setHeader(pht('PROPERTIES')) ->setHeader(pht('Properties'))
->addActionLink($add_button); ->addActionLink($add_button);
return id(new PHUIObjectBoxView()) return id(new PHUIObjectBoxView())

2
src/applications/almanac/controller/AlmanacServiceViewController.php
View File

@@ -81,7 +81,7 @@ final class AlmanacServiceViewController
$service->getServiceImplementation()->getServiceTypeShortName()); $service->getServiceImplementation()->getServiceTypeShortName());
return id(new PHUIObjectBoxView()) return id(new PHUIObjectBoxView())
->setHeaderText(pht('DETAILS')) ->setHeaderText(pht('Details'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->appendChild($properties); ->appendChild($properties);
} }

2
src/applications/badges/controller/PhabricatorBadgesViewController.php
View File

@@ -72,7 +72,7 @@ final class PhabricatorBadgesViewController
$timeline, $timeline,
$comment_view, $comment_view,
)) ))
->addPropertySection(pht('DESCRIPTION'), $details); ->addPropertySection(pht('Description'), $details);
return $this->newPage() return $this->newPage()
->setTitle($title) ->setTitle($title)

4
src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
View File

@@ -94,8 +94,8 @@ final class PhabricatorCalendarEventViewController
$add_comment_form, $add_comment_form,
)) ))
->setCurtain($curtain) ->setCurtain($curtain)
->addPropertySection(pht('DETAILS'), $details) ->addPropertySection(pht('Details'), $details)
->addPropertySection(pht('DESCRIPTION'), $description); ->addPropertySection(pht('Description'), $description);
return $this->newPage() return $this->newPage()
->setTitle($page_title) ->setTitle($page_title)

2
src/applications/daemon/controller/PhabricatorDaemonBulkJobViewController.php
View File

@@ -29,7 +29,7 @@ final class PhabricatorDaemonBulkJobViewController
$curtain = $this->buildCurtainView($job); $curtain = $this->buildCurtainView($job);
$box = id(new PHUIObjectBoxView()) $box = id(new PHUIObjectBoxView())
->setHeaderText(pht('DETAILS')) ->setHeaderText(pht('Details'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->addPropertyList($properties); ->addPropertyList($properties);

2
src/applications/dashboard/controller/PhabricatorDashboardManageController.php
View File

@@ -198,7 +198,7 @@ final class PhabricatorDashboardManageController
$viewer->renderHandleList($dashboard->getPanelPHIDs())); $viewer->renderHandleList($dashboard->getPanelPHIDs()));
return id(new PHUIObjectBoxView()) return id(new PHUIObjectBoxView())
->setHeaderText(pht('DETAILS')) ->setHeaderText(pht('Details'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->addPropertyList($properties); ->addPropertyList($properties);
} }

2
src/applications/dashboard/controller/PhabricatorDashboardPanelViewController.php
View File

@@ -165,7 +165,7 @@ final class PhabricatorDashboardPanelViewController
: phutil_tag('em', array(), $does_not_appear)); : phutil_tag('em', array(), $does_not_appear));
return id(new PHUIObjectBoxView()) return id(new PHUIObjectBoxView())
->setHeaderText(pht('DETAILS')) ->setHeaderText(pht('Details'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->addPropertyList($properties); ->addPropertyList($properties);
} }

2
src/applications/differential/controller/DifferentialRevisionViewController.php
View File

@@ -480,7 +480,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
} }
$header = id(new PHUIHeaderView()) $header = id(new PHUIHeaderView())
->setHeader(pht('DETAILS')); ->setHeader(pht('Details'));
return id(new PHUIObjectBoxView()) return id(new PHUIObjectBoxView())
->setHeader($header) ->setHeader($header)

8
src/applications/diffusion/controller/DiffusionBrowseController.php
View File

@@ -310,7 +310,7 @@ final class DiffusionBrowseController extends DiffusionController {
)); ));
if ($properties) { if ($properties) {
$view->addPropertySection(pht('DETAILS'), $properties); $view->addPropertySection(pht('Details'), $properties);
} }
$title = array($basename, $repository->getDisplayName()); $title = array($basename, $repository->getDisplayName());
@@ -413,7 +413,7 @@ final class DiffusionBrowseController extends DiffusionController {
)); ));
if ($details) { if ($details) {
$view->addPropertySection(pht('DETAILS'), $details); $view->addPropertySection(pht('Details'), $details);
} }
return $this->newPage() return $this->newPage()
@@ -1409,7 +1409,7 @@ final class DiffusionBrowseController extends DiffusionController {
$file = $this->renderFileButton($file_uri); $file = $this->renderFileButton($file_uri);
$header = id(new PHUIHeaderView()) $header = id(new PHUIHeaderView())
->setHeader(pht('DETAILS')) ->setHeader(pht('Details'))
->addActionLink($file); ->addActionLink($file);
$box = id(new PHUIObjectBoxView()) $box = id(new PHUIObjectBoxView())
@@ -1426,7 +1426,7 @@ final class DiffusionBrowseController extends DiffusionController {
->appendChild($message); ->appendChild($message);
$header = id(new PHUIHeaderView()) $header = id(new PHUIHeaderView())
->setHeader(pht('DETAILS')); ->setHeader(pht('Details'));
$box = id(new PHUIObjectBoxView()) $box = id(new PHUIObjectBoxView())
->setHeader($header) ->setHeader($header)

4
src/applications/diffusion/controller/DiffusionCommitController.php
View File

@@ -355,8 +355,8 @@ final class DiffusionCommitController extends DiffusionController {
$change_list, $change_list,
$add_comment, $add_comment,
)) ))
->addPropertySection(pht('DESCRIPTION'), $detail_list) ->addPropertySection(pht('Description'), $detail_list)
->addPropertySection(pht('DETAILS'), $details) ->addPropertySection(pht('Details'), $details)
->setCurtain($curtain); ->setCurtain($curtain);
$page = $this->newPage() $page = $this->newPage()

4
src/applications/diffusion/controller/DiffusionRepositoryController.php
View File

@@ -288,7 +288,7 @@ final class DiffusionRepositoryController extends DiffusionController {
$description = new PHUIRemarkupView($viewer, $description); $description = new PHUIRemarkupView($viewer, $description);
$view->addTextContent($description); $view->addTextContent($description);
return id(new PHUIObjectBoxView()) return id(new PHUIObjectBoxView())
->setHeaderText(pht('DESCRIPTION')) ->setHeaderText(pht('Description'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->appendChild($view); ->appendChild($view);
} }
@@ -354,7 +354,7 @@ final class DiffusionRepositoryController extends DiffusionController {
} }
$box = id(new PHUIObjectBoxView()) $box = id(new PHUIObjectBoxView())
->setHeaderText(pht('DETAILS')) ->setHeaderText(pht('Details'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->appendChild($view); ->appendChild($view);

2
src/applications/fund/controller/FundInitiativeViewController.php
View File

@@ -62,7 +62,7 @@ final class FundInitiativeViewController
$timeline, $timeline,
$add_comment, $add_comment,
)) ))
->addPropertySection(pht('DETAILS'), $details); ->addPropertySection(pht('Details'), $details);
return $this->newPage() return $this->newPage()
->setTitle($title) ->setTitle($title)

2
src/applications/harbormaster/controller/HarbormasterBuildViewController.php
View File

@@ -539,7 +539,7 @@ final class HarbormasterBuildViewController
$this->getStatus($build)); $this->getStatus($build));
return id(new PHUIObjectBoxView()) return id(new PHUIObjectBoxView())
->setHeaderText(pht('PROPERTIES')) ->setHeaderText(pht('Properties'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->appendChild($properties); ->appendChild($properties);

2
src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
View File

@@ -178,7 +178,7 @@ final class HarbormasterBuildableViewController
: pht('Automatic Buildable')); : pht('Automatic Buildable'));
return id(new PHUIObjectBoxView()) return id(new PHUIObjectBoxView())
->setHeaderText(pht('PROPERTIES')) ->setHeaderText(pht('Properties'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->appendChild($properties); ->appendChild($properties);
} }

2
src/applications/harbormaster/controller/HarbormasterStepViewController.php
View File

@@ -104,7 +104,7 @@ final class HarbormasterStepViewController
} }
return id(new PHUIObjectBoxView()) return id(new PHUIObjectBoxView())
->setHeaderText(pht('PROPERTIES')) ->setHeaderText(pht('Properties'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->appendChild($view); ->appendChild($view);
} }

4
src/applications/herald/controller/HeraldRuleViewController.php
View File

@@ -54,8 +54,8 @@ final class HeraldRuleViewController extends HeraldController {
->setHeader($header) ->setHeader($header)
->setCurtain($curtain) ->setCurtain($curtain)
->setMainColumn($timeline) ->setMainColumn($timeline)
->addPropertySection(pht('DETAILS'), $details) ->addPropertySection(pht('Details'), $details)
->addPropertySection(pht('DESCRIPTION'), $description); ->addPropertySection(pht('Description'), $description);
return $this->newPage() return $this->newPage()
->setTitle($title) ->setTitle($title)

2
src/applications/legalpad/controller/LegalpadDocumentManageController.php
View File

@@ -176,7 +176,7 @@ final class LegalpadDocumentManageController extends LegalpadController {
} }
return id(new PHUIObjectBoxView()) return id(new PHUIObjectBoxView())
->setHeaderText(pht('PROPERTIES')) ->setHeaderText(pht('Properties'))
->addPropertyList($properties) ->addPropertyList($properties)
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY); ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY);
} }

4
src/applications/macro/controller/PhabricatorMacroViewController.php
View File

@@ -72,8 +72,8 @@ final class PhabricatorMacroViewController
$timeline, $timeline,
$add_comment_form, $add_comment_form,
)) ))
->addPropertySection(pht('MACRO'), $file) ->addPropertySection(pht('Macro'), $file)
->addPropertySection(pht('DETAILS'), $details); ->addPropertySection(pht('Details'), $details);
return $this->newPage() return $this->newPage()
->setTitle($title_short) ->setTitle($title_short)

4
src/applications/maniphest/controller/ManiphestTaskDetailController.php
View File

@@ -88,8 +88,8 @@ final class ManiphestTaskDetailController extends ManiphestController {
$timeline, $timeline,
$comment_view, $comment_view,
)) ))
->addPropertySection(pht('DESCRIPTION'), $description) ->addPropertySection(pht('Description'), $description)
->addPropertySection(pht('DETAILS'), $details); ->addPropertySection(pht('Details'), $details);
return $this->newPage() return $this->newPage()
->setTitle($title) ->setTitle($title)

2
src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
View File

@@ -63,7 +63,7 @@ final class PhabricatorApplicationDetailViewController
$policies, $policies,
$panels, $panels,
)) ))
->addPropertySection(pht('DETAILS'), $details); ->addPropertySection(pht('Details'), $details);
return $this->newPage() return $this->newPage()
->setTitle($title) ->setTitle($title)

2
src/applications/nuance/controller/NuanceItemManageController.php
View File

@@ -40,7 +40,7 @@ final class NuanceItemManageController extends NuanceController {
$view = id(new PHUITwoColumnView()) $view = id(new PHUITwoColumnView())
->setHeader($header) ->setHeader($header)
->setCurtain($curtain) ->setCurtain($curtain)
->addPropertySection(pht('DETAILS'), $properties) ->addPropertySection(pht('Details'), $properties)
->setMainColumn($timeline); ->setMainColumn($timeline);
return $this->newPage() return $this->newPage()

4
src/applications/nuance/controller/NuanceSourceViewController.php
View File

@@ -40,8 +40,8 @@ final class NuanceSourceViewController
$view = id(new PHUITwoColumnView()) $view = id(new PHUITwoColumnView())
->setHeader($header) ->setHeader($header)
->setCurtain($curtain) ->setCurtain($curtain)
->addPropertySection(pht('DETAILS'), $properties) ->addPropertySection(pht('Details'), $properties)
->addPropertySection(pht('ROUTING'), $routing_list) ->addPropertySection(pht('Routing'), $routing_list)
->setMainColumn($timeline); ->setMainColumn($timeline);
return $this->newPage() return $this->newPage()

2
src/applications/passphrase/controller/PassphraseCredentialViewController.php
View File

@@ -36,7 +36,7 @@ final class PassphraseCredentialViewController extends PassphraseController {
->setSubheader($subheader) ->setSubheader($subheader)
->setCurtain($curtain) ->setCurtain($curtain)
->setMainColumn($timeline) ->setMainColumn($timeline)
->addPropertySection(pht('PROPERTIES'), $content); ->addPropertySection(pht('Properties'), $content);
return $this->newPage() return $this->newPage()
->setTitle($title) ->setTitle($title)

2
src/applications/people/controller/PhabricatorPeopleProfileManageController.php
View File

@@ -57,7 +57,7 @@ final class PhabricatorPeopleProfileManageController
$manage = id(new PHUITwoColumnView()) $manage = id(new PHUITwoColumnView())
->setHeader($header) ->setHeader($header)
->setCurtain($curtain) ->setCurtain($curtain)
->addPropertySection(pht('DETAILS'), $properties) ->addPropertySection(pht('Details'), $properties)
->setMainColumn( ->setMainColumn(
array( array(
$timeline, $timeline,

2
src/applications/phlux/controller/PhluxViewController.php
View File

@@ -41,7 +41,7 @@ final class PhluxViewController extends PhluxController {
$timeline->setShouldTerminate(true); $timeline->setShouldTerminate(true);
$object_box = id(new PHUIObjectBoxView()) $object_box = id(new PHUIObjectBoxView())
->setHeaderText(pht('DETAILS')) ->setHeaderText(pht('Details'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->addPropertyList($properties); ->addPropertyList($properties);

4
src/applications/phortune/controller/PhortuneMerchantViewController.php
View File

@@ -131,7 +131,7 @@ final class PhortuneMerchantViewController
$view->addProperty(pht('Status'), $status_view); $view->addProperty(pht('Status'), $status_view);
return id(new PHUIObjectBoxView()) return id(new PHUIObjectBoxView())
->setHeaderText(pht('DETAILS')) ->setHeaderText(pht('Details'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->appendChild($view); ->appendChild($view);
} }
@@ -146,7 +146,7 @@ final class PhortuneMerchantViewController
$description = new PHUIRemarkupView($viewer, $description); $description = new PHUIRemarkupView($viewer, $description);
$view->addTextContent($description); $view->addTextContent($description);
return id(new PHUIObjectBoxView()) return id(new PHUIObjectBoxView())
->setHeaderText(pht('DESCRIPTION')) ->setHeaderText(pht('Description'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->appendChild($view); ->appendChild($view);
} }

2
src/applications/phortune/controller/PhortuneProductViewController.php
View File

@@ -38,7 +38,7 @@ final class PhortuneProductViewController extends PhortuneController {
$product->getPriceAsCurrency()->formatForDisplay()); $product->getPriceAsCurrency()->formatForDisplay());
$object_box = id(new PHUIObjectBoxView()) $object_box = id(new PHUIObjectBoxView())
->setHeaderText(pht('DETAILS')) ->setHeaderText(pht('Details'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->addPropertyList($properties); ->addPropertyList($properties);

2
src/applications/phortune/controller/PhortuneSubscriptionViewController.php
View File

@@ -82,7 +82,7 @@ final class PhortuneSubscriptionViewController extends PhortuneController {
$autopay_method); $autopay_method);
$details = id(new PHUIObjectBoxView()) $details = id(new PHUIObjectBoxView())
->setHeaderText(pht('DETAILS')) ->setHeaderText(pht('Details'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->addPropertyList($properties); ->addPropertyList($properties);

2
src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
View File

@@ -145,7 +145,7 @@ final class PhabricatorPhurlURLViewController
} }
return id(new PHUIObjectBoxView()) return id(new PHUIObjectBoxView())
->setHeaderText(pht('DETAILS')) ->setHeaderText(pht('Details'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->appendChild($properties); ->appendChild($properties);
} }

2
src/applications/ponder/controller/PonderQuestionViewController.php
View File

@@ -119,7 +119,7 @@ final class PonderQuestionViewController extends PonderController {
->setSubheader($subheader) ->setSubheader($subheader)
->setCurtain($curtain) ->setCurtain($curtain)
->setMainColumn($ponder_content) ->setMainColumn($ponder_content)
->addPropertySection(pht('DETAILS'), $details) ->addPropertySection(pht('Details'), $details)
->addClass('ponder-question-view'); ->addClass('ponder-question-view');
$page_objects = array_merge( $page_objects = array_merge(

2
src/applications/project/controller/PhabricatorProjectManageController.php
View File

@@ -48,7 +48,7 @@ final class PhabricatorProjectManageController
$manage = id(new PHUITwoColumnView()) $manage = id(new PHUITwoColumnView())
->setHeader($header) ->setHeader($header)
->setCurtain($curtain) ->setCurtain($curtain)
->addPropertySection(pht('DETAILS'), $properties) ->addPropertySection(pht('Details'), $properties)
->setMainColumn( ->setMainColumn(
array( array(
$timeline, $timeline,

2
src/applications/spaces/controller/PhabricatorSpacesViewController.php
View File

@@ -45,7 +45,7 @@ final class PhabricatorSpacesViewController
} }
$box = id(new PHUIObjectBoxView()) $box = id(new PHUIObjectBoxView())
->setHeaderText(pht('DETAILS')) ->setHeaderText(pht('Details'))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->addPropertyList($property_list); ->addPropertyList($property_list);