Explicitly load assets in revision list

Summary:
Rendering method shouldn't load data.
The view probably shouldn't load data either because it is a job for component (object that both loads data and displays them) but we don't have that concept in Phabricator.
This at least improves the architecture a little bit.

Test Plan: /differential/

Reviewers: epriestley

Reviewed By: epriestley

CC: alanh, aran, Korvin

Differential Revision: https://secure.phabricator.com/D3325
This commit is contained in:
vrana
2012-08-17 12:46:26 -07:00
parent b50cdc6e43
commit 8ee2a6f988
5 changed files with 31 additions and 11 deletions

View File

@@ -326,7 +326,8 @@ final class PhabricatorDirectoryMainController
->setHighlightAge(true)
->setRevisions($active)
->setFields(DifferentialRevisionListView::getDefaultFields())
->setUser($user);
->setUser($user)
->loadAssets();
$phids = array_merge(
array($user_phid),
$revision_view->getRequiredHandlePHIDs());