archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Set viewer for all handles loaded in controllers

Browse Source 
Summary:
I've replaced all `id(new PhabricatorObjectHandleData(...))->loadHandles()` by `$this->loadViewerHandles(...)`.
Lint caught one usage in a static method.

Test Plan: Displayed revision with sporadic author.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3432
This commit is contained in:
vrana
2012-09-04 19:02:56 -07:00
parent efd59322f2
commit 8ff52c0b6c
65 changed files with 91 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/diffusion/controller/DiffusionBrowseController.php
View File

@@ -79,7 +79,7 @@ final class DiffusionBrowseController extends DiffusionController {
}
$phids = array_keys($phids);
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$handles = $this->loadViewerHandles($phids);
$browse_table = new DiffusionBrowseTableView();
$browse_table->setDiffusionRequest($drequest);

9
src/applications/diffusion/controller/DiffusionCommitController.php
View File

@@ -361,8 +361,7 @@ final class DiffusionCommitController extends DiffusionController {
$handles = array();
if ($phids) {
$handles = id(new PhabricatorObjectHandleData($phids))
->loadHandles();
$handles = $this->loadViewerHandles($phids);
}
$props = array();
@@ -469,7 +468,7 @@ final class DiffusionCommitController extends DiffusionController {
$view->setShowDescriptions(false);
$phids = $view->getRequiredHandlePHIDs();
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$handles = $this->loadViewerHandles($phids);
$view->setHandles($handles);
$view->setAuthorityPHIDs($this->auditAuthorityPHIDs);
$this->highlightedAudits = $view->getHighlightedAudits();
@@ -509,7 +508,7 @@ final class DiffusionCommitController extends DiffusionController {
$view->setPathMap($path_map);
$phids = $view->getRequiredHandlePHIDs();
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$handles = $this->loadViewerHandles($phids);
$view->setHandles($handles);
return $view;
@@ -757,7 +756,7 @@ final class DiffusionCommitController extends DiffusionController {
$history_table->loadRevisions();
$phids = $history_table->getRequiredHandlePHIDs();
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$handles = $this->loadViewerHandles($phids);
$history_table->setHandles($handles);
$panel = new AphrontPanelView();

3
src/applications/diffusion/controller/DiffusionCommitEditController.php
View File

@@ -42,8 +42,7 @@ final class DiffusionCommitEditController extends DiffusionController {
$commit_phid,
$edge_type
);
$handles = id(new PhabricatorObjectHandleData($current_proj_phids))
->loadHandles();
$handles = $this->loadViewerHandles($current_proj_phids);
$proj_t_values = mpull($handles, 'getFullName', 'getPHID');
if ($request->isFormPost()) {

2
src/applications/diffusion/controller/DiffusionController.php
View File

@@ -141,7 +141,7 @@ abstract class DiffusionController extends PhabricatorController {
->loadAssets();
$phids = $view->getRequiredHandlePHIDs();
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$handles = $this->loadViewerHandles($phids);
$view->setHandles($handles);
$panel = new AphrontPanelView();

2
src/applications/diffusion/controller/DiffusionDiffController.php
View File

@@ -94,7 +94,7 @@ final class DiffusionDiffController extends DiffusionController {
}
$phids = mpull($inlines, 'getAuthorPHID');
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$handles = $this->loadViewerHandles($phids);
$parser->setHandles($handles);
}

2
src/applications/diffusion/controller/DiffusionHistoryController.php
View File

@@ -84,7 +84,7 @@ final class DiffusionHistoryController extends DiffusionController {
$history_table->loadRevisions();
$phids = $history_table->getRequiredHandlePHIDs();
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$handles = $this->loadViewerHandles($phids);
$history_table->setHandles($handles);
if ($show_graph) {

2
src/applications/diffusion/controller/DiffusionLastModifiedController.php
View File

@@ -37,7 +37,7 @@ final class DiffusionLastModifiedController extends DiffusionController {
}
$phids = array_keys($phids);
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$handles = $this->loadViewerHandles($phids);
$output = DiffusionBrowseTableView::renderLastModifiedColumns(
$drequest->getRepository(),

4
src/applications/diffusion/controller/DiffusionRepositoryController.php
View File

@@ -64,7 +64,7 @@ final class DiffusionRepositoryController extends DiffusionController {
}
$phids = array_keys($phids);
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$handles = $this->loadViewerHandles($phids);
$history_table = new DiffusionHistoryTableView();
$history_table->setDiffusionRequest($drequest);
@@ -240,7 +240,7 @@ final class DiffusionRepositoryController extends DiffusionController {
$view->setCommits($commits);
$phids = $view->getRequiredHandlePHIDs();
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$handles = $this->loadViewerHandles($phids);
$view->setHandles($handles);
$panel = new AphrontPanelView();

2
src/applications/diffusion/controller/DiffusionTagListController.php
View File

@@ -72,7 +72,7 @@ final class DiffusionTagListController extends DiffusionController {
->setDiffusionRequest($drequest);
$phids = $view->getRequiredHandlePHIDs();
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$handles = $this->loadViewerHandles($phids);
$view->setHandles($handles);
$panel = id(new AphrontPanelView())