archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Set viewer for all handles loaded in controllers

Browse Source 
Summary:
I've replaced all `id(new PhabricatorObjectHandleData(...))->loadHandles()` by `$this->loadViewerHandles(...)`.
Lint caught one usage in a static method.

Test Plan: Displayed revision with sporadic author.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3432
This commit is contained in:
vrana
2012-09-04 19:02:56 -07:00
parent efd59322f2
commit 8ff52c0b6c
65 changed files with 91 additions and 139 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/applications/directory/controller/PhabricatorDirectoryMainController.php
View File

@@ -332,7 +332,7 @@ final class PhabricatorDirectoryMainController
$phids = array_merge(
array($user_phid),
$revision_view->getRequiredHandlePHIDs());
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$handles = $this->loadViewerHandles($phids);
$revision_view->setHandles($handles);
@@ -385,7 +385,7 @@ final class PhabricatorDirectoryMainController
array_filter(mpull($tasks, 'getOwnerPHID')),
array_mergev(mpull($tasks, 'getProjectPHIDs')));
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$handles = $this->loadViewerHandles($phids);
$view = new ManiphestTaskListView();
$view->setTasks($tasks);
@@ -623,7 +623,7 @@ final class PhabricatorDirectoryMainController
$view->setUser($user);
$phids = $view->getRequiredHandlePHIDs();
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$handles = $this->loadViewerHandles($phids);
$view->setHandles($handles);
$panel = new AphrontPanelView();
@@ -667,7 +667,7 @@ final class PhabricatorDirectoryMainController
$view->setUser($user);
$phids = $view->getRequiredHandlePHIDs();
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
$handles = $this->loadViewerHandles($phids);
$view->setHandles($handles);
$panel = new AphrontPanelView();