archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Various fixes, particularly on the revision update workflow.

Browse Source
This commit is contained in:
epriestley
2011-02-04 17:53:14 -08:00
parent 8b7755b834
commit 905870d793
26 changed files with 308 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/applications/differential/controller/revisionedit/DifferentialRevisionEditController.php
View File

@@ -133,6 +133,21 @@ class DifferentialRevisionEditController extends DifferentialController {
->setErrors($errors);
}
if ($diff && $revision->getID()) {
$form
->appendChild(
id(new AphrontFormTextAreaControl())
->setLabel('Comments')
->setName('comments')
->setCaption("Explain what's new in this diff.")
->setValue($request->getStr('comments')))
->appendChild(
id(new AphrontFormSubmitControl())
->setValue('Save'))
->appendChild(
id(new AphrontFormDividerControl()));
}
$form
->appendChild(
id(new AphrontFormTextAreaControl())
@@ -190,7 +205,11 @@ class DifferentialRevisionEditController extends DifferentialController {
$panel = new AphrontPanelView();
if ($revision->getID()) {
$panel->setHeader('Edit Differential Revision');
if ($diff) {
$panel->setHeader('Update Differential Revision');
} else {
$panel->setHeader('Edit Differential Revision');
}
} else {
$panel->setHeader('Create New Differential Revision');
}