archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Misc Phame Updates

Browse Source 
Summary: Color nodata as nodata, fix picture redirect, give hints when items aren't set on blogs. Ref T9897

Test Plan: Tested each of these items.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T9897

Differential Revision: https://secure.phabricator.com/D14657
This commit is contained in:
Chad Little
2015-12-03 13:54:08 -08:00
parent 39903769f0
commit 905d0f43b1
3 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/applications/phame/controller/blog/PhameBlogManageController.php
View File

@@ -80,13 +80,18 @@ final class PhameBlogManageController extends PhameBlogController {
->setObject($blog) ->setObject($blog)
->setActionList($actions); ->setActionList($actions);
$properties->addProperty( $skin = $blog->getSkin();
pht('Skin'), if (!$skin) {
$blog->getSkin()); $skin = pht('(No external skin)');
}
$properties->addProperty( $domain = $blog->getDomain();
pht('Domain'), if (!$domain) {
$blog->getDomain()); $domain = pht('(No external domain)');
}
$properties->addProperty(pht('Skin'), $skin);
$properties->addProperty(pht('Domain'), $domain);
$feed_uri = PhabricatorEnv::getProductionURI( $feed_uri = PhabricatorEnv::getProductionURI(
$this->getApplicationURI('blog/feed/'.$blog->getID().'/')); $this->getApplicationURI('blog/feed/'.$blog->getID().'/'));

2
src/applications/phame/controller/blog/PhameBlogProfilePictureController.php
View File

@@ -25,7 +25,7 @@ final class PhameBlogProfilePictureController
return new Aphront404Response(); return new Aphront404Response();
} }
$blog_uri = '/phame/blog/view/'.$id; $blog_uri = '/phame/blog/manage/'.$id;
$supported_formats = PhabricatorFile::getTransformableImageFormats(); $supported_formats = PhabricatorFile::getTransformableImageFormats();
$e_file = true; $e_file = true;

3
src/applications/phame/view/PhamePostListView.php
View File

@@ -57,7 +57,7 @@ final class PhamePostListView extends AphrontTagView {
$phame_post = PhabricatorMarkupEngine::summarize($post->getBody()); $phame_post = PhabricatorMarkupEngine::summarize($post->getBody());
$phame_post = new PHUIRemarkupView($viewer, $phame_post); $phame_post = new PHUIRemarkupView($viewer, $phame_post);
} else { } else {
$phame_post = phutil_tag('em', array(), pht('Empty Post')); $phame_post = phutil_tag('em', array(), pht('(Empty Post)'));
} }
$blogger = phutil_tag('strong', array(), $blogger); $blogger = phutil_tag('strong', array(), $blogger);
@@ -101,6 +101,7 @@ final class PhamePostListView extends AphrontTagView {
if (empty($list)) { if (empty($list)) {
$list = id(new PHUIInfoView()) $list = id(new PHUIInfoView())
->setSeverity(PHUIInfoView::SEVERITY_NODATA)
->appendChild($nodata); ->appendChild($nodata);
} }