Streamline Files interfaces
Summary: - There's no way you can figure out the ID of a file right now. Expose that more prominently. - Put the drag-and-drop uploader on the main page so you don't have to click through. - Restore the basic uploader so IE users can theoretically use the suite I guess? Added author info to basic uploader. - Show author information in the table. - Show date information in the table. - Link file names. - Rename table for filter views. - When you upload one file, just jump to it. When you upload multiple files, jump to your uploads and highlight them. - Add an "arc download" hint. Test Plan: Uploaded single files, groups of files, and files via simple uploader. Reviewers: codeblock, jungejason, tuomaspelkonen, aran Commenters: codeblock CC: aran, codeblock, epriestley Differential Revision: 746
This commit is contained in:
@@ -94,6 +94,9 @@ class PhabricatorFileViewController extends PhabricatorFileController {
|
||||
$form->setAction('/file/download/'.$file->getPHID().'/');
|
||||
$button_name = 'Download File';
|
||||
}
|
||||
|
||||
$file_id = 'F'.$file->getID();
|
||||
|
||||
$form->setUser($user);
|
||||
$form
|
||||
->appendChild(
|
||||
@@ -101,6 +104,14 @@ class PhabricatorFileViewController extends PhabricatorFileController {
|
||||
->setLabel('Name')
|
||||
->setName('name')
|
||||
->setValue($file->getName()))
|
||||
->appendChild(
|
||||
id(new AphrontFormStaticControl())
|
||||
->setLabel('ID')
|
||||
->setName('id')
|
||||
->setValue($file_id)
|
||||
->setCaption(
|
||||
'Download this file with: <tt>arc download '.
|
||||
phutil_escape_html($file_id).'</tt>'))
|
||||
->appendChild(
|
||||
id(new AphrontFormStaticControl())
|
||||
->setLabel('PHID')
|
||||
|
||||
Reference in New Issue
Block a user