Move "Macros" to a first-class application
Summary: This is mostly to unblock D3547. - Move "Macros" to a first-class application called "Macros". - After D3547, this application will also house "Memes" (macros with text on them). - This will also make them easier to find; the top navigational query I field is "where are image macros?" nowadays, since it's not intuitive they're part of files. - This makes some of the UI mobile-aware but doesn't set the `device` flag yet, since there are still some missing pieces. - I'll separate storage out and continue modernizing the UI as we unblock and integrate D3547. Test Plan: Created, edited and deleted macros. Viewed files. Reviewers: btrahan, vrana, teisenbe Reviewed By: vrana CC: aran Maniphest Tasks: T175 Differential Revision: https://secure.phabricator.com/D3572
This commit is contained in:
45
src/applications/macro/storage/PhabricatorFileImageMacro.php
Normal file
45
src/applications/macro/storage/PhabricatorFileImageMacro.php
Normal file
@@ -0,0 +1,45 @@
|
||||
<?php
|
||||
|
||||
/*
|
||||
* Copyright 2012 Facebook, Inc.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software
|
||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
final class PhabricatorFileImageMacro extends PhabricatorFileDAO {
|
||||
|
||||
protected $filePHID;
|
||||
protected $name;
|
||||
|
||||
public function getConfiguration() {
|
||||
return array(
|
||||
self::CONFIG_TIMESTAMPS => false,
|
||||
) + parent::getConfiguration();
|
||||
}
|
||||
|
||||
static public function newFromImageURI($uri, $file_name, $image_macro_name) {
|
||||
$file = PhabricatorFile::newFromFileDownload($uri, $file_name);
|
||||
|
||||
if (!$file) {
|
||||
return null;
|
||||
}
|
||||
|
||||
$image_macro = new PhabricatorFileImageMacro();
|
||||
$image_macro->setName($image_macro_name);
|
||||
$image_macro->setFilePHID($file->getPHID());
|
||||
$image_macro->save();
|
||||
|
||||
return $image_macro;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user