Add missing expected keys and uniqueness

Summary:
Ref T1191.

  - Adds definitions for missing keys and keys with wrong uniqueness. Generally, I defined these before fixing the key query to actually pull all keys and support uniqueness.
  - Moves "key uniqueness" to note severity; this is fixable (probably?) and there are no remaining issues.
  - Moves "Missing Key" to note severity; missing keys are fixable and all remaining missing keys are really missing (either missing edge keys, or missing PHID keys):

{F210089}

  - Moves "Surplus Key" to note seveirty; surplus keys are fixable all remaining surplus keys are really surplus (duplicate key in Harbormaster, key on unused column in Worker):

{F210090}

Test Plan:
  - Vetted missing/surplus/unique messages.
  - 146 issues remaining.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10590

src/applications/cache/storage/PhabricatorCacheSchemaSpec.php

@@ -20,9 +20,17 @@ final class PhabricatorCacheSchemaSpec extends PhabricatorConfigSchemaSpec {
       array(
         'PRIMARY' => array(
           'columns' => array('id'),
+          'unique' => true,
         ),
         'key_cacheKeyHash' => array(
           'columns' => array('cacheKeyHash'),
+          'unique' => true,
+        ),
+        'key_cacheCreated' => array(
+          'columns' => array('cacheCreated'),
+        ),
+        'key_ttl' => array(
+          'columns' => array('cacheExpires'),
         ),
       ));
 

src/applications/cache/storage/PhabricatorMarkupCache.php

@@ -21,6 +21,10 @@ final class PhabricatorMarkupCache extends PhabricatorCacheDAO {
       self::CONFIG_KEY_SCHEMA => array(
         'cacheKey' => array(
           'columns' => array('cacheKey'),
+          'unique' => true,
+        ),
+        'dateCreated' => array(
+          'columns' => array('dateCreated'),
         ),
       ),
     ) + parent::getConfiguration();