Add missing expected keys and uniqueness
Summary:
Ref T1191.
- Adds definitions for missing keys and keys with wrong uniqueness. Generally, I defined these before fixing the key query to actually pull all keys and support uniqueness.
- Moves "key uniqueness" to note severity; this is fixable (probably?) and there are no remaining issues.
- Moves "Missing Key" to note severity; missing keys are fixable and all remaining missing keys are really missing (either missing edge keys, or missing PHID keys):
{F210089}
- Moves "Surplus Key" to note seveirty; surplus keys are fixable all remaining surplus keys are really surplus (duplicate key in Harbormaster, key on unused column in Worker):
{F210090}
Test Plan:
- Vetted missing/surplus/unique messages.
- 146 issues remaining.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T1191
Differential Revision: https://secure.phabricator.com/D10590
This commit is contained in:
@@ -89,10 +89,17 @@ final class PhabricatorConfigDatabaseIssueController
|
||||
foreach ($issues as $issue) {
|
||||
$const = $issue[4];
|
||||
|
||||
$database_link = phutil_tag(
|
||||
'a',
|
||||
array(
|
||||
'href' => $this->getApplicationURI('/database/'.$issue[0].'/'),
|
||||
),
|
||||
$issue[0]);
|
||||
|
||||
$rows[] = array(
|
||||
$this->renderIcon(
|
||||
PhabricatorConfigStorageSchema::getIssueStatus($const)),
|
||||
$issue[0],
|
||||
$database_link,
|
||||
$issue[1],
|
||||
$issue[2],
|
||||
$issue[3],
|
||||
|
||||
Reference in New Issue
Block a user