Cover redirects to files in more cases

Summary: Ref T5894. We have a couple more similar cases. Make them all do a decision-based redirect for now.

Test Plan: Did "View Raw File" and such, and also made sure thumbnails still work.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5894

Differential Revision: https://secure.phabricator.com/D10301

src/applications/files/controller/PhabricatorFileTransformController.php

@@ -148,22 +148,8 @@ final class PhabricatorFileTransformController
 
     // TODO: We could just delegate to the file view controller instead,
     // which would save the client a roundtrip, but is slightly more complex.
-    $uri = $file->getBestURI();
 
-    // TODO: This is a bit iffy. Sometimes, getBestURI() returns a CDN URI
-    // (if the file is a viewable image) and sometimes a local URI (if not).
-    // For now, just detect which one we got and configure the response
-    // appropriately. In the long run, if this endpoint is served from a CDN
-    // domain, we can't issue a local redirect to an info URI (which is not
-    // present on the CDN domain). We probably never actually issue local
-    // redirects here anyway, since we only ever transform viewable images
-    // right now.
-
-    $is_external = strlen(id(new PhutilURI($uri))->getDomain());
-
-    return id(new AphrontRedirectResponse())
-      ->setIsExternal($is_external)
-      ->setURI($uri);
+    return $file->getRedirectResponse();
   }
 
   private function executePreviewTransform(PhabricatorFile $file, $size) {