Add objectheaders to new View

Summary: This adds the 'PHUIObjectBox' to nearly every place that should get it. I need to comb through Diffusion a little more. I've left Differential mostly alone, but may decide to do it anyways this weekend. I'm sure I missed something else, but these are easy enough to update.

Test Plan: tested each new layout.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: Korvin, aran

Differential Revision: https://secure.phabricator.com/D7162
This commit is contained in:
Chad Little
2013-09-28 15:55:38 -07:00
parent 0318cadad4
commit 94d0704fdb
61 changed files with 526 additions and 365 deletions

View File

@@ -137,9 +137,13 @@ final class DiffusionCommitController extends DiffusionController {
),
$message));
$content[] = $top_anchor;
$content[] = $headsup_view;
$content[] = $headsup_actions;
$content[] = $property_list;
$object_box = id(new PHUIObjectBoxView())
->setHeader($headsup_view)
->addContent($headsup_actions)
->addContent($property_list);
$content[] = $object_box;
}
$content[] = $this->buildComments($commit);
@@ -646,7 +650,6 @@ final class DiffusionCommitController extends DiffusionController {
$form = id(new AphrontFormView())
->setUser($user)
->setShaded(true)
->setAction('/audit/addcomment/')
->addHiddenInput('commit', $commit->getPHID())
->appendChild(
@@ -738,19 +741,22 @@ final class DiffusionCommitController extends DiffusionController {
// Differential better.
require_celerity_resource('differential-core-view-css');
$comment_box = id(new PHUIObjectBoxView())
->setHeader($header)
->addContent($form);
return phutil_tag(
'div',
array(
'id' => $pane_id,
),
hsprintf(
'<div class="differential-add-comment-panel">%s%s%s%s</div>',
'<div class="differential-add-comment-panel">%s%s%s</div>',
id(new PhabricatorAnchorView())
->setAnchorName('comment')
->setNavigationMarker(true)
->render(),
$header,
$form,
$comment_box,
$preview_panel));
}