Revamp Projects with new navigation
Summary:
A refresh of Projects including a new navigations UI.
- New Navigation UI.
- Auto switch default page if Workboard has been initialized
- Move Feed to it's own page
- Increase 'tasks' on Project Home to 50 over 10
- Fix various display bugs on Workboards
- Remove 'crumbs' from Project portal (unneeded).
Test Plan:
- clicked a link for a project with no workboard and saw the profile
- clicked a link for a project with a workboard and saw the workboard
- navigated around the various edit pages, inspecting links and making sure things linked back to the new profile uri
{F266460}
{F266461}
{F266462}
{F266463}
{F266464}
Reviewers: epriestley, btrahan
Reviewed By: epriestley, btrahan
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D11272
This commit is contained in:
@@ -14,12 +14,14 @@ final class PhabricatorProjectEditDetailsController
|
||||
$viewer = $request->getUser();
|
||||
|
||||
if ($this->id) {
|
||||
$is_new = false;
|
||||
$id = $request->getURIData('id');
|
||||
$is_new = false;
|
||||
|
||||
$project = id(new PhabricatorProjectQuery())
|
||||
->setViewer($viewer)
|
||||
->withIDs(array($this->id))
|
||||
->needSlugs(true)
|
||||
->needImages(true)
|
||||
->requireCapabilities(
|
||||
array(
|
||||
PhabricatorPolicyCapability::CAN_VIEW,
|
||||
@@ -149,7 +151,7 @@ final class PhabricatorProjectEditDetailsController
|
||||
|
||||
if ($is_new) {
|
||||
$redirect_uri =
|
||||
$this->getApplicationURI('view/'.$project->getID().'/');
|
||||
$this->getApplicationURI('profile/'.$project->getID().'/');
|
||||
} else {
|
||||
$redirect_uri =
|
||||
$this->getApplicationURI('edit/'.$project->getID().'/');
|
||||
@@ -300,22 +302,17 @@ final class PhabricatorProjectEditDetailsController
|
||||
->setValidationException($validation_exception)
|
||||
->setForm($form);
|
||||
|
||||
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
|
||||
if ($is_new) {
|
||||
$crumbs->addTextCrumb($title);
|
||||
if (!$is_new) {
|
||||
$nav = $this->buildIconNavView($project);
|
||||
$nav->selectFilter("edit/{$id}/");
|
||||
$nav->appendChild($form_box);
|
||||
} else {
|
||||
$crumbs
|
||||
->addTextCrumb($project->getName(),
|
||||
$this->getApplicationURI('view/'.$project->getID().'/'))
|
||||
->addTextCrumb(pht('Edit'),
|
||||
$this->getApplicationURI('edit/'.$project->getID().'/'))
|
||||
->addTextCrumb(pht('Details'));
|
||||
$nav = array($form_box);
|
||||
}
|
||||
|
||||
return $this->buildApplicationPage(
|
||||
array(
|
||||
$crumbs,
|
||||
$form_box,
|
||||
$nav,
|
||||
),
|
||||
array(
|
||||
'title' => $title,
|
||||
|
||||
Reference in New Issue
Block a user