archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Rename PHIDType classes

Browse Source 
Summary: Ref T5655. Rename `PhabricatorPHIDType` subclasses for clarity (see discussion in D9839). I'm not too keen on some of the resulting class names, so feel free to suggest alternatives.

Test Plan: Ran unit tests.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin, hach-que

Maniphest Tasks: T5655

Differential Revision: https://secure.phabricator.com/D9986
This commit is contained in:
Joshua Spence
2014-07-24 08:05:46 +10:00
parent 9a892dd906
commit 97a8700e45
221 changed files with 418 additions and 425 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
resources/sql/patches/20130926.dinline.php
View File

@@ -34,15 +34,15 @@ foreach ($rows as $row) {
if ($row['commentID']) {
$xaction_phid = PhabricatorPHID::generateNewPHID(
PhabricatorApplicationTransactionPHIDTypeTransaction::TYPECONST,
DifferentialPHIDTypeRevision::TYPECONST);
PhabricatorApplicationTransactionTransactionPHIDType::TYPECONST,
DifferentialRevisionPHIDType::TYPECONST);
} else {
$xaction_phid = null;
}
$comment_phid = PhabricatorPHID::generateNewPHID(
PhabricatorPHIDConstants::PHID_TYPE_XCMT,
DifferentialPHIDTypeRevision::TYPECONST);
DifferentialRevisionPHIDType::TYPECONST);
queryfx(
$conn_w,