PHUIPropertyListView

Summary: This builds out and implements PHUIPropertyListView (container) and PHUIPropertyListItemView (section) as well as adding tabs.

Test Plan: Tested each page I edited with the exception of Releeph and Phortune, though those changes look ok to me diff wise. Updated examples page with tabs.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7283
This commit is contained in:
Chad Little
2013-10-11 07:53:56 -07:00
parent f8d963a77e
commit 97c690fc0f
54 changed files with 581 additions and 417 deletions

View File

@@ -39,13 +39,12 @@ final class PhabricatorApplicationDetailViewController
$header->setStatus('open', 'red', pht('Uninstalled'));
}
$properties = $this->buildPropertyView($selected);
$actions = $this->buildActionView($user, $selected);
$properties = $this->buildPropertyView($selected, $actions);
$object_box = id(new PHUIObjectBoxView())
->setHeader($header)
->setActionList($actions)
->setPropertyList($properties);
->addPropertyList($properties);
return $this->buildApplicationPage(
array(
@@ -58,11 +57,15 @@ final class PhabricatorApplicationDetailViewController
));
}
private function buildPropertyView(PhabricatorApplication $application) {
private function buildPropertyView(
PhabricatorApplication $application,
PhabricatorActionListView $actions) {
$viewer = $this->getRequest()->getUser();
$properties = id(new PhabricatorPropertyListView())
$properties = id(new PHUIPropertyListView())
->addProperty(pht('Description'), $application->getShortDescription());
$properties->setActionList($actions);
if ($application->isBeta()) {
$properties->addProperty(