archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Set $can_edit for Harbormaster steps

Browse Source 
Summary: Sets the `$can_edit` value correctly (previously it was hardcoded to `true`).

Test Plan: Went to http://phabricator.local/harbormaster/step/view/1/ and saw "Edit Step" disabled.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14373
This commit is contained in:
Joshua Spence
2015-10-31 04:54:16 +00:00
committed by joshuaspence
parent 4d13b6c6a8
commit 98a301a59b
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/applications/harbormaster/controller/HarbormasterStepViewController.php
View File

@@ -97,7 +97,10 @@ final class HarbormasterStepViewController extends HarbormasterController {
->setUser($viewer) ->setUser($viewer)
->setObject($step); ->setObject($step);
$can_edit = true; $can_edit = PhabricatorPolicyFilter::hasCapability(
$viewer,
$step,
PhabricatorPolicyCapability::CAN_EDIT);
$list->addAction( $list->addAction(
id(new PhabricatorActionView()) id(new PhabricatorActionView())