Move "List Inline Comments" to the inline header dropdown menu

Summary: See D18128. Ref T12733. Ref T8250.

Test Plan: {F5003153}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12733, T8250

Differential Revision: https://secure.phabricator.com/D18129
This commit is contained in:
epriestley
2017-06-15 05:31:42 -07:00
parent b3b30dde6a
commit 9b93697d52
6 changed files with 72 additions and 33 deletions

View File

@@ -281,6 +281,12 @@ final class DifferentialRevisionViewController extends DifferentialController {
->setTitle(pht('Diff %s', $target->getID()))
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY);
$revision_id = $revision->getID();
$inline_list_uri = "/revision/inlines/{$revision_id}/";
$inline_list_uri = $this->getApplicationURI($inline_list_uri);
$changeset_view->setInlineListURI($inline_list_uri);
if ($repository) {
$changeset_view->setRepository($repository);
}
@@ -574,12 +580,6 @@ final class DifferentialRevisionViewController extends DifferentialController {
->setDisabled(!$can_edit)
->setWorkflow(!$can_edit));
$curtain->addAction(
id(new PhabricatorActionView())
->setIcon('fa-indent')
->setHref("/differential/revision/inlines/{$revision_id}/")
->setName(pht('List Inline Comments')));
$curtain->addAction(
id(new PhabricatorActionView())
->setIcon('fa-upload')