Conpherence - add ability to change title in the durable column

Summary: Ref T7014.

Test Plan: changed the conpherence title from the column. since i can't get scrolling to work, i inspect the dom to verify the title change transaction showed up properly

Reviewers: epriestley, chad

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7014

Differential Revision: https://secure.phabricator.com/D12002
This commit is contained in:
Bob Trahan
2015-03-09 12:09:43 -07:00
parent 10a84d66db
commit 9b9a8001fa
7 changed files with 93 additions and 30 deletions

View File

@@ -108,7 +108,9 @@ final class ConpherenceUpdateController
->setTransactionType(ConpherenceTransactionType::TYPE_TITLE)
->setNewValue($title);
$updated = true;
$response_mode = 'redirect';
if (!$request->getExists('force_ajax')) {
$response_mode = 'redirect';
}
}
if (!$updated) {
$errors[] = pht(
@@ -271,7 +273,7 @@ final class ConpherenceUpdateController
->setValue($conpherence->getTitle()));
require_celerity_resource('conpherence-update-css');
return id(new AphrontDialogView())
$view = id(new AphrontDialogView())
->setTitle(pht('Update Conpherence'))
->addHiddenInput('action', 'metadata')
->addHiddenInput(
@@ -279,6 +281,15 @@ final class ConpherenceUpdateController
$request->getInt('latest_transaction_id'))
->addHiddenInput('__continue__', true)
->appendChild($form);
if ($request->getExists('minimal_display')) {
$view->addHiddenInput('minimal_display', true);
}
if ($request->getExists('force_ajax')) {
$view->addHiddenInput('force_ajax', true);
}
return $view;
}
private function loadAndRenderUpdates(
@@ -361,8 +372,10 @@ final class ConpherenceUpdateController
if ($people_widget) {
$people_html = hsprintf('%s', $people_widget->render());
}
$title = $this->getConpherenceTitle($conpherence);
$content = array(
'transactions' => hsprintf('%s', $rendered_transactions),
'conpherence_title' => (string) $title,
'latest_transaction_id' => $new_latest_transaction_id,
'nav_item' => hsprintf('%s', $nav_item),
'conpherence_phid' => $conpherence->getPHID(),