Fix "unmarked 0 inline comments as not undone" transactions
Summary: Fixes T8483. I did this incorrectly in D13159, by doing it correctly first and then editing it carelessly. For most transaction types, it didn't matter, but did for inline state. Also, clean up any bad inline state transactions. Test Plan: - Ran migration, bad transactions vanished. - Marked some inline comments as done. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T8483 Differential Revision: https://secure.phabricator.com/D13226
This commit is contained in:
@@ -356,6 +356,7 @@ abstract class PhabricatorApplicationTransactionEditor
|
||||
case PhabricatorTransactions::TYPE_BUILDABLE:
|
||||
case PhabricatorTransactions::TYPE_TOKEN:
|
||||
case PhabricatorTransactions::TYPE_INLINESTATE:
|
||||
return $xaction->getNewValue();
|
||||
case PhabricatorTransactions::TYPE_SPACE:
|
||||
$space_phid = $xaction->getNewValue();
|
||||
if (!strlen($space_phid)) {
|
||||
|
||||
Reference in New Issue
Block a user