archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Namespace dateCreated in Maniphest query construction

Browse Source 
Summary: Fixes T5661. We may now pick up a conflicting `dateCreated` field from an edge table join.

Test Plan: Ran a project + dateCreated filtering query, no longer got an exception.

Reviewers: btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T5661

Differential Revision: https://secure.phabricator.com/D9997
This commit is contained in:
epriestley
2014-07-21 06:44:35 -07:00
parent af214ecb65
commit 9d64beeaa3
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/applications/maniphest/query/ManiphestTaskQuery.php
View File

@@ -206,28 +206,28 @@ final class ManiphestTaskQuery extends PhabricatorCursorPagedPolicyAwareQuery {
if ($this->dateCreatedAfter) { if ($this->dateCreatedAfter) {
$where[] = qsprintf( $where[] = qsprintf(
$conn, $conn,
'dateCreated >= %d', 'task.dateCreated >= %d',
$this->dateCreatedAfter); $this->dateCreatedAfter);
} }
if ($this->dateCreatedBefore) { if ($this->dateCreatedBefore) {
$where[] = qsprintf( $where[] = qsprintf(
$conn, $conn,
'dateCreated <= %d', 'task.dateCreated <= %d',
$this->dateCreatedBefore); $this->dateCreatedBefore);
} }
if ($this->dateModifiedAfter) { if ($this->dateModifiedAfter) {
$where[] = qsprintf( $where[] = qsprintf(
$conn, $conn,
'dateModified >= %d', 'task.dateModified >= %d',
$this->dateModifiedAfter); $this->dateModifiedAfter);
} }
if ($this->dateModifiedBefore) { if ($this->dateModifiedBefore) {
$where[] = qsprintf( $where[] = qsprintf(
$conn, $conn,
'dateModified <= %d', 'task.dateModified <= %d',
$this->dateModifiedBefore); $this->dateModifiedBefore);
} }