archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix visibility of some LiskDAO methods

Browse Source 
Summary: Ref T6822.

Test Plan: Ran unit tests.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T6822

Differential Revision: https://secure.phabricator.com/D11410
This commit is contained in:
Joshua Spence
2015-01-16 07:43:51 +11:00
parent daadf95537
commit 9f29af108b
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/infrastructure/storage/lisk/__tests__/LiskIsolationTestCase.php
View File

@@ -45,7 +45,9 @@ final class LiskIsolationTestCase extends PhabricatorTestCase {
$dao = new LiskIsolationTestDAO(); $dao = new LiskIsolationTestDAO();
try { try {
$dao->establishLiveConnection('r'); $method = new ReflectionMethod($dao, 'establishLiveConnection');
$method->setAccessible(true);
$method->invoke($dao, 'r');
$this->assertFailure( $this->assertFailure(
'LiskIsolationTestDAO did not throw an exception when instructed to '. 'LiskIsolationTestDAO did not throw an exception when instructed to '.

4
src/infrastructure/storage/lisk/__tests__/LiskIsolationTestDAO.php
View File

@@ -15,13 +15,13 @@ final class LiskIsolationTestDAO extends LiskDAO {
return PhabricatorPHID::generateNewPHID('TISO'); return PhabricatorPHID::generateNewPHID('TISO');
} }
public function establishLiveConnection($mode) { protected function establishLiveConnection($mode) {
throw new LiskIsolationTestDAOException( throw new LiskIsolationTestDAOException(
'Isolation failure! DAO is attempting to connect to an external '. 'Isolation failure! DAO is attempting to connect to an external '.
'resource!'); 'resource!');
} }
public function getConnectionNamespace() { protected function getConnectionNamespace() {
return 'test'; return 'test';
} }