Clean up feedback from D11340

Summary: Ref D11340, I missed the comments being to excited to land.

Test Plan: Shrink window to mobile view, click on action menu.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11347
This commit is contained in:
Chad Little
2015-01-12 08:21:17 -08:00
parent 0d070c91dc
commit 9f4a3226ea
4 changed files with 6 additions and 31 deletions
+3 -3
View File
@@ -170,7 +170,7 @@ final class PHUIObjectBoxView extends AphrontView {
$meta = array(
'map' => array(
$this->actionListID => 'phabricator-action-list-toggle',
$icon_id => 'phui-mobile-action-menu-open',
$icon_id => 'phuix-dropdown-open',
),);
$mobile_menu = id(new PHUIButtonView())
->setTag('a')
@@ -179,8 +179,8 @@ final class PHUIObjectBoxView extends AphrontView {
->setIcon($icon)
->addClass('phui-mobile-menu')
->setID($icon_id)
->setSigil('jx-toggle-class')
->setMeta($meta);
->addSigil('jx-toggle-class')
->setMetadata($meta);
$header->addActionLink($mobile_menu);
}