archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Sort Spaces dropdown by name, not "alphabetical ID"

Browse Source 
Summary:
Fixes T10414. I think this sorted by name at one time (the `asort()`) but then I probably added "Space SX" in front of it. Or I just got this wrong from the beginning.

Instead, sort by space name.

Test Plan: {F1126034}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10414

Differential Revision: https://secure.phabricator.com/D15334
This commit is contained in:
epriestley
2016-02-23 10:30:07 -08:00
parent 0799c91822
commit a112bc5cba
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php
View File

@@ -184,6 +184,7 @@ final class PhabricatorSpacesNamespaceQuery
$space_phid) { $space_phid) {
$viewer_spaces = self::getViewerSpaces($viewer); $viewer_spaces = self::getViewerSpaces($viewer);
$viewer_spaces = msort($viewer_spaces, 'getNamespaceName');
$map = array(); $map = array();
foreach ($viewer_spaces as $space) { foreach ($viewer_spaces as $space) {
@@ -200,7 +201,6 @@ final class PhabricatorSpacesNamespaceQuery
$space->getMonogram(), $space->getMonogram(),
$space->getNamespaceName()); $space->getNamespaceName());
} }
asort($map);
return $map; return $map;
} }