archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Allow projects to be set as policies

Browse Source 
Summary:
  - Renames `PhabricatorPolicyQuery` to `PhabricatorPolicyAwareQuery` (a query which respects policy settings).
  - Introduces `PhabricatorPolicyQuery`, which loads available policies (e.g., "member of project X").
  - Introduces `PhabricatorPolicy`, which describes a policy.
  - Allows projects to be set as policies.
  - Allows Paste policies to be edited.
  - Covers crazy cases where you make projects depend on themselves or each other because you are a dastardly villan.

Test Plan: Set paste and project policies, including crazy policies like A -> B -> A, A -> A, etc.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D3476
This commit is contained in:
epriestley
2012-09-13 10:15:08 -07:00
parent b39175342d
commit a1df1f2b70
20 changed files with 524 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
src/view/form/control/AphrontFormPolicyControl.php
View File

@@ -21,6 +21,7 @@ final class AphrontFormPolicyControl extends AphrontFormControl {
private $user;
private $object;
private $capability;
private $policies;
public function setUser(PhabricatorUser $user) {
$this->user = $user;
@@ -36,6 +37,12 @@ final class AphrontFormPolicyControl extends AphrontFormControl {
return $this;
}
public function setPolicies(array $policies) {
assert_instances_of($policies, 'PhabricatorPolicy');
$this->policies = $policies;
return $this;
}
public function setCapability($capability) {
$this->capability = $capability;
@@ -54,35 +61,18 @@ final class AphrontFormPolicyControl extends AphrontFormControl {
return 'aphront-form-control-policy';
}
private function getOptions() {
$show_public = PhabricatorEnv::getEnvConfig('policy.allow-public');
if ($this->capability != PhabricatorPolicyCapability::CAN_VIEW) {
// We don't generally permit 'public' for anything except viewing.
$show_public = false;
}
if ($this->getValue() == PhabricatorPolicies::POLICY_PUBLIC) {
// If the object already has a "public" policy, show the option in
// the dropdown even if it will be enforced as "users", so we don't
// change the policy just because the config is changing.
$show_public = true;
}
protected function getOptions() {
$options = array();
foreach ($this->policies as $policy) {
if (($policy->getPHID() == PhabricatorPolicies::POLICY_PUBLIC) &&
($this->capability != PhabricatorPolicyCapability::CAN_VIEW)) {
// Never expose "Public" for anything except "Can View".
continue;
}
if ($show_public) {
$options[PhabricatorPolicies::POLICY_PUBLIC] = 'Public';
$type_name = PhabricatorPolicyType::getPolicyTypeName($policy->getType());
$options[$type_name][$policy->getPHID()] = $policy->getFullName();
}
$options[PhabricatorPolicies::POLICY_USER] = 'All Users';
if ($this->user->getIsAdmin()) {
$options[PhabricatorPolicies::POLICY_ADMIN] = 'Administrators';
}
$options[PhabricatorPolicies::POLICY_NOONE] = 'No One';
return $options;
}