archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix AphrontCrumbView (phutil_tag)

Browse Source 
Summary: Proper fix is to do some layout work in Diffusion. Short of that, make this escape properly.

Test Plan: Viewed various crumbs, no more overescaping for non-diffusion crumbs.

Reviewers: vrana

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D4641
This commit is contained in:
epriestley
2013-01-25 17:07:07 -08:00
parent b9f394164f
commit a1ff679f41
2 changed files with 15 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/applications/diffusion/controller/DiffusionController.php
View File

@@ -246,9 +246,9 @@ abstract class DiffusionController extends PhabricatorController {
break;
case 'change':
$view_name = 'Change';
$crumb_list[] = $crumb->setRawName(
phutil_escape_html($path).' ('.$commit_link.')'
);
$crumb_list[] = $crumb->setName(
phutil_safe_html(
phutil_escape_html($path).' ('.$commit_link.')'));
return $crumb_list;
}
@@ -293,7 +293,7 @@ abstract class DiffusionController extends PhabricatorController {
$path_sections = '/'.implode('/', $path_sections);
$crumb_list[] = id(new PhabricatorCrumbView())
->setRawName($path_sections);
->setName(phutil_safe_html($path_sections));
}
$last_crumb = array_pop($crumb_list);
@@ -308,13 +308,14 @@ abstract class DiffusionController extends PhabricatorController {
) + $uri_params),
),
'Jump to HEAD');
$last_crumb->setRawName(
$last_crumb->getNameForRender() . " @ {$commit_link} ({$jump_link})"
);
$name = $last_crumb->getName();
$name = phutil_safe_html($name." @ {$commit_link} ({$jump_link})");
$last_crumb->setName($name);
} else if ($spec['view'] != 'lint') {
$last_crumb->setRawName(
$last_crumb->getNameForRender() . " @ HEAD"
);
$name = $last_crumb->getName();
$name = phutil_safe_html($name.' @ HEAD');
$last_crumb->setName($name);
}
$crumb_list[] = $last_crumb;