archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Conpherence - fix off by one bug in calendar data fetching

Browse Source 
Summary: Ref T3155. "last sunday" is "last sunday at 00:00" so you have to include a day for Sunday itself.

Test Plan: calendar renders correctly today - saturday - which is the edge case of this

Reviewers: epriestley, chad

Reviewed By: chad

CC: aran, Korvin

Maniphest Tasks: T3155

Differential Revision: https://secure.phabricator.com/D6108
This commit is contained in:
Bob Trahan
2013-06-01 10:20:13 -07:00
parent 0bd8374c63
commit a20e87bc16
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/conpherence/controller/ConpherenceWidgetController.php
View File

@@ -385,7 +385,7 @@ final class ConpherenceWidgetController extends
$first_day = new DateTime('last sunday', $timezone); $first_day = new DateTime('last sunday', $timezone);
$timestamps = array(); $timestamps = array();
for ($day = 0; $day < 8; $day++) { for ($day = 0; $day < 9; $day++) {
$timestamp = clone $first_day; $timestamp = clone $first_day;
$timestamps[] = $timestamp->modify(sprintf('+%d days', $day)); $timestamps[] = $timestamp->modify(sprintf('+%d days', $day));
} }

2
src/applications/conpherence/query/ConpherenceThreadQuery.php
View File

@@ -225,7 +225,7 @@ final class ConpherenceThreadQuery
$this->getViewer(), $this->getViewer(),
'U'); 'U');
$end_epoch = phabricator_format_local_time( $end_epoch = phabricator_format_local_time(
strtotime('last sunday +8 days', strtotime('tomorrow')), strtotime('last sunday +9 days', strtotime('tomorrow')),
$this->getViewer(), $this->getViewer(),
'U'); 'U');
$statuses = id(new PhabricatorUserStatus()) $statuses = id(new PhabricatorUserStatus())