Apply lint rules to Phabricator

Summary: Mostly applies a new call spacing rule; also a few things that have slipped through via pull requests and such

Test Plan: `find src/ -type f -name '*.php' | xargs -n16 arc lint --output summary --apply-patches`

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D5002
This commit is contained in:
epriestley
2013-02-19 13:33:10 -08:00
parent 63f35ee94f
commit a22bea2a74
128 changed files with 341 additions and 662 deletions

View File

@@ -63,8 +63,7 @@ final class ConpherenceViewController extends
$conpherence = $this->getConpherence();
$display_data = $conpherence->getDisplayData(
$user,
ConpherenceImageData::SIZE_HEAD
);
ConpherenceImageData::SIZE_HEAD);
$edit_href = $this->getApplicationURI('update/'.$conpherence->getID().'/');
$class_mod = $display_data['image_class'];
@@ -74,8 +73,7 @@ final class ConpherenceViewController extends
array(
'class' => 'upload-photo'
),
pht('Drop photo here to change this Conpherence photo.')
).
pht('Drop photo here to change this Conpherence photo.')).
javelin_tag(
'a',
array(
@@ -83,30 +81,26 @@ final class ConpherenceViewController extends
'href' => $edit_href,
'sigil' => 'workflow edit-action',
),
''
).
'').
phutil_tag(
'div',
array(
'class' => $class_mod.'header-image',
'style' => 'background-image: url('.$display_data['image'].');'
),
''
).
'').
phutil_tag(
'div',
array(
'class' => $class_mod.'title',
),
$display_data['title']
).
$display_data['title']).
phutil_tag(
'div',
array(
'class' => $class_mod.'subtitle',
),
$display_data['subtitle']
);
$display_data['subtitle']);
return array('header' => $header);
}
@@ -154,12 +148,10 @@ final class ConpherenceViewController extends
->appendChild(
id(new PhabricatorRemarkupControl())
->setUser($user)
->setName('text')
)
->setName('text'))
->appendChild(
id(new AphrontFormSubmitControl())
->setValue(pht('Pontificate'))
)->render();
->setValue(pht('Pontificate')))->render();
$scrollbutton = javelin_tag(
'a',