Apply lint rules to Phabricator

Summary: Mostly applies a new call spacing rule; also a few things that have slipped through via pull requests and such

Test Plan: `find src/ -type f -name '*.php' | xargs -n16 arc lint --output summary --apply-patches`

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D5002

src/applications/diffusion/controller/DiffusionChangeController.php

@@ -14,7 +14,7 @@ final class DiffusionChangeController extends DiffusionController {
       // TODO: Refine this.
       return new Aphront404Response();
     }
-    
+
     $repository = $drequest->getRepository();
     $callsign = $repository->getCallsign();
     $commit = $drequest->getRawCommit();

src/applications/diffusion/controller/DiffusionCommitController.php

@@ -40,8 +40,7 @@ final class DiffusionCommitController extends DiffusionController {
         ->setTitle('Error displaying commit.')
         ->appendChild('Failed to load the commit because the commit has not '.
                       'been parsed yet.'),
-          array('title' => 'Commit Still Parsing')
-        );
+          array('title' => 'Commit Still Parsing'));
     }
 
     $commit_data = $drequest->loadCommitData();
@@ -83,8 +82,7 @@ final class DiffusionCommitController extends DiffusionController {
       $commit_properties = $this->loadCommitProperties(
         $commit,
         $commit_data,
-        $parent_query->loadParents()
-      );
+        $parent_query->loadParents());
       $property_list = id(new PhabricatorPropertyListView())
         ->setHasKeyboardShortcuts(true);
       foreach ($commit_properties as $key => $value) {
@@ -280,8 +278,7 @@ final class DiffusionCommitController extends DiffusionController {
 
       $change_list_title = DiffusionView::nameCommit(
         $repository,
-        $commit->getCommitIdentifier()
-      );
+        $commit->getCommitIdentifier());
       $change_list = new DifferentialChangesetListView();
       $change_list->setTitle($change_list_title);
       $change_list->setChangesets($changesets);
@@ -320,8 +317,7 @@ final class DiffusionCommitController extends DiffusionController {
     $commit_id = 'r'.$callsign.$commit->getCommitIdentifier();
     $short_name = DiffusionView::nameCommit(
       $repository,
-      $commit->getCommitIdentifier()
-    );
+      $commit->getCommitIdentifier());
 
     $crumbs = $this->buildCrumbs(array(
       'commit' => true,
@@ -351,8 +347,7 @@ final class DiffusionCommitController extends DiffusionController {
       $content,
       array(
         'title' => $commit_id
-      )
-    );
+      ));
   }
 
   private function loadCommitProperties(
@@ -373,11 +368,9 @@ final class DiffusionCommitController extends DiffusionController {
       ->execute();
 
     $task_phids = array_keys(
-      $edges[$commit_phid][PhabricatorEdgeConfig::TYPE_COMMIT_HAS_TASK]
-    );
+      $edges[$commit_phid][PhabricatorEdgeConfig::TYPE_COMMIT_HAS_TASK]);
     $proj_phids = array_keys(
-      $edges[$commit_phid][PhabricatorEdgeConfig::TYPE_COMMIT_HAS_PROJECT]
-    );
+      $edges[$commit_phid][PhabricatorEdgeConfig::TYPE_COMMIT_HAS_PROJECT]);
 
     $phids = array_merge($task_phids, $proj_phids);
     if ($data->getCommitDetail('authorPHID')) {

src/applications/diffusion/controller/DiffusionCommitEditController.php

@@ -24,8 +24,7 @@ final class DiffusionCommitEditController extends DiffusionController {
     $edge_type          = PhabricatorEdgeConfig::TYPE_COMMIT_HAS_PROJECT;
     $current_proj_phids = PhabricatorEdgeQuery::loadDestinationPHIDs(
       $commit_phid,
-      $edge_type
-    );
+      $edge_type);
     $handles = $this->loadViewerHandles($current_proj_phids);
     $proj_t_values = mpull($handles, 'getFullName', 'getPHID');
 

src/applications/diffusion/controller/DiffusionController.php

@@ -188,14 +188,12 @@ abstract class DiffusionController extends PhabricatorController {
       $crumb = new PhabricatorCrumbView();
       if ($spec['commit']) {
         $crumb->setName(
-          "Tags for r{$callsign}{$raw_commit}"
-        );
+          "Tags for r{$callsign}{$raw_commit}");
         $crumb->setHref($drequest->generateURI(
           array(
             'action' => 'commit',
             'commit' => $raw_commit,
-          ))
-        );
+          )));
       } else {
         $crumb->setName('Tags');
       }
@@ -264,8 +262,7 @@ abstract class DiffusionController extends PhabricatorController {
       $crumb->setHref($drequest->generateURI(
         array(
           'path' => '',
-        ) + $uri_params)
-      );
+        ) + $uri_params));
       $crumb_list[] = $crumb;
 
       $path_parts = explode('/', $path);