Apply lint rules to Phabricator

Summary: Mostly applies a new call spacing rule; also a few things that have slipped through via pull requests and such

Test Plan: `find src/ -type f -name '*.php' | xargs -n16 arc lint --output summary --apply-patches`

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D5002

src/applications/diffusion/controller/DiffusionController.php

@@ -188,14 +188,12 @@ abstract class DiffusionController extends PhabricatorController {
       $crumb = new PhabricatorCrumbView();
       if ($spec['commit']) {
         $crumb->setName(
-          "Tags for r{$callsign}{$raw_commit}"
-        );
+          "Tags for r{$callsign}{$raw_commit}");
         $crumb->setHref($drequest->generateURI(
           array(
             'action' => 'commit',
             'commit' => $raw_commit,
-          ))
-        );
+          )));
       } else {
         $crumb->setName('Tags');
       }
@@ -264,8 +262,7 @@ abstract class DiffusionController extends PhabricatorController {
       $crumb->setHref($drequest->generateURI(
         array(
           'path' => '',
-        ) + $uri_params)
-      );
+        ) + $uri_params));
       $crumb_list[] = $crumb;
 
       $path_parts = explode('/', $path);