archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Apply lint rules to Phabricator

Browse Source 
Summary: Mostly applies a new call spacing rule; also a few things that have slipped through via pull requests and such

Test Plan: `find src/ -type f -name '*.php' | xargs -n16 arc lint --output summary --apply-patches`

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D5002
This commit is contained in:
epriestley
2013-02-19 13:33:10 -08:00
parent 63f35ee94f
commit a22bea2a74
128 changed files with 341 additions and 662 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
View File

@@ -72,8 +72,7 @@ final class PhabricatorApplicationDetailViewController
private function buildPropertyView(PhabricatorApplication $selected) {
$properties = id(new PhabricatorPropertyListView())
->addProperty(
pht('Description'), $selected->getShortDescription()
);
pht('Description'), $selected->getShortDescription());
return $properties;
}
@@ -92,8 +91,7 @@ final class PhabricatorApplicationDetailViewController
->setIcon('delete')
->setWorkflow(true)
->setHref(
$this->getApplicationURI(get_class($selected).'/uninstall/'))
);
$this->getApplicationURI(get_class($selected).'/uninstall/')));
} else {
$view->addAction(
id(new PhabricatorActionView())
@@ -101,8 +99,7 @@ final class PhabricatorApplicationDetailViewController
->setIcon('new')
->setWorkflow(true)
->setHref(
$this->getApplicationURI(get_class($selected).'/install/'))
);
$this->getApplicationURI(get_class($selected).'/install/')));
}
} else {
$view->addAction(
@@ -112,8 +109,7 @@ final class PhabricatorApplicationDetailViewController
->setWorkflow(true)
->setDisabled(true)
->setHref(
$this->getApplicationURI(get_class($selected).'/uninstall/'))
);
$this->getApplicationURI(get_class($selected).'/uninstall/')));
}
return $view;
}