Apply lint rules to Phabricator

Summary: Mostly applies a new call spacing rule; also a few things that have slipped through via pull requests and such

Test Plan: `find src/ -type f -name '*.php' | xargs -n16 arc lint --output summary --apply-patches`

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D5002
This commit is contained in:
epriestley
2013-02-19 13:33:10 -08:00
parent 63f35ee94f
commit a22bea2a74
128 changed files with 341 additions and 662 deletions

View File

@@ -94,8 +94,7 @@ final class PhabricatorPeopleProfileController
->setIsExternal(true)
->setName($name)
->setHref($href)
->setType(PhabricatorMenuItemView::TYPE_LINK)
);
->setType(PhabricatorMenuItemView::TYPE_LINK));
}
}
@@ -149,16 +148,14 @@ final class PhabricatorPeopleProfileController
$nav->addFilter(
null,
pht('Edit Profile...'),
'/settings/panel/profile/'
);
'/settings/panel/profile/');
}
if ($viewer->getIsAdmin()) {
$nav->addFilter(
null,
pht('Administrate User...'),
'/people/edit/'.$user->getID().'/'
);
'/people/edit/'.$user->getID().'/');
}
return $this->buildApplicationPage(
@@ -172,8 +169,7 @@ final class PhabricatorPeopleProfileController
$blurb = nonempty(
$profile->getBlurb(),
'//'.pht('Nothing is known about this rare specimen.').'//'
);
'//'.pht('Nothing is known about this rare specimen.').'//');
$engine = PhabricatorMarkupEngine::newProfileMarkupEngine();
$blurb = $engine->markupText($blurb);