Replace some hsprintf() by phutil_tag()

Test Plan: Looked at a diff with inline comment.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7549

src/applications/people/controller/PhabricatorPeopleEditController.php

@@ -414,8 +414,8 @@ final class PhabricatorPeopleEditController
 
     if ($is_self) {
       $inst = pht('NOTE: You can not edit your own role.');
-      $form->appendChild(hsprintf(
-        '<p class="aphront-form-instructions">%s</p>', $inst));
+      $form->appendChild(
+        phutil_tag('p', array('class' => 'aphront-form-instructions'), $inst));
     }
 
     $form
@@ -473,8 +473,8 @@ final class PhabricatorPeopleEditController
     $form
       ->setUser($admin)
       ->setAction($request->getRequestURI())
-      ->appendChild(hsprintf(
-        '<p class="aphront-form-instructions">%s</p>', $inst));
+      ->appendChild(
+        phutil_tag('p', array('class' => 'aphront-form-instructions'), $inst));
 
     if ($user->getIsSystemAgent()) {
       $form
@@ -703,11 +703,10 @@ final class PhabricatorPeopleEditController
       ),
       pht('User Guide: Account Roles'));
 
-    $inst = pht('For a detailed explanation of account roles, see %s.',
-      $roles_link);
-    return hsprintf(
-      '<p class="aphront-form-instructions">%s</p>',
-      $inst);
+    return phutil_tag(
+      'p',
+      array('class' => 'aphront-form-instructions'),
+      pht('For a detailed explanation of account roles, see %s.', $roles_link));
   }
 
   private function processSetAccountPicture(PhabricatorUser $user) {

src/applications/people/controller/PhabricatorPeopleProfileController.php

@@ -127,10 +127,8 @@ final class PhabricatorPeopleProfileController
     $builder->setShowHovercards(true);
     $view = $builder->buildView();
 
-    return hsprintf(
-      '<div class="profile-feed profile-wrap-responsive">
-        %s
-      </div>',
+    return phutil_tag_div(
+      'profile-feed profile-wrap-responsive',
       $view->render());
   }
 }