Show the difference between a committer and an author

Summary:
Git and hg (supposedly..) differentiate between an author (who wrote the patch)
and a committer (who applied the patch).

This patch allows Phabricator to note when a patch is committed
by someone other than the Author.

Test Plan:
Created 2 accounts,
 - U (Account with a PHID)
 - U' (Account without a PHID)
and had them create and commit commits

testing if their username/real name would be displayed correctly in Diffusion,
  - BrowserTable
  - HistoryTable
  - Code revision

Teztz,
A(uthor)/C(ommitter)
If it's A/A then Author committed

UL = User link (<a href="/p/username">username</a>)
UN = User name ("Firstname Lastname")

Tezt | Expected in table  | Got
-------------------------------------------
A/A   | UL/UL             | UL/UL
A'/C  | UN/UL             | UN/UL
A/C'  | UL/UN             | UL/UN
A'/C' | UN/UN             | UN/UN

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Maniphest Tasks: T688

Differential Revision: https://secure.phabricator.com/D2541

src/applications/diffusion/controller/commit/DiffusionCommitController.php

@@ -287,6 +287,9 @@ final class DiffusionCommitController extends DiffusionController {
     if ($data->getCommitDetail('reviewerPHID')) {
       $phids[] = $data->getCommitDetail('reviewerPHID');
     }
+    if ($data->getCommitDetail('committerPHID')) {
+      $phids[] = $data->getCommitDetail('committerPHID');
+    }
     if ($data->getCommitDetail('differential.revisionPHID')) {
       $phids[] = $data->getCommitDetail('differential.revisionPHID');
     }
@@ -330,6 +333,17 @@ final class DiffusionCommitController extends DiffusionController {
       $props['Reviewer'] = phutil_escape_html($reviewer_name);
     }
 
+    $committer = $data->getCommitDetail('committer');
+    if ($committer) {
+      $committer_phid = $data->getCommitDetail('committerPHID');
+      if ($data->getCommitDetail('committerPHID')) {
+        $props['Committer'] = $handles[$committer_phid]->renderLink();
+      } else {
+        $props['Committer'] = phutil_escape_html($committer);
+      }
+    }
+
+
     $revision_phid = $data->getCommitDetail('differential.revisionPHID');
     if ($revision_phid) {
       $props['Differential Revision'] = $handles[$revision_phid]->renderLink();

src/applications/diffusion/controller/lastmodified/DiffusionLastModifiedController.php

@@ -27,10 +27,16 @@ final class DiffusionLastModifiedController extends DiffusionController {
     list($commit, $commit_data) = $modified_query->loadLastModification();
 
     $phids = array();
-    if ($commit_data && $commit_data->getCommitDetail('authorPHID')) {
-      $phids = array($commit_data->getCommitDetail('authorPHID'));
+    if ($commit_data) {
+      if ($commit_data->getCommitDetail('authorPHID')) {
+        $phids[$commit_data->getCommitDetail('authorPHID')] = true;
+      }
+      if ($commit_data->getCommitDetail('committerPHID')) {
+        $phids[$commit_data->getCommitDetail('committerPHID')] = true;
+      }
     }
 
+    $phids = array_keys($phids);
     $handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
 
     $output = DiffusionBrowseTableView::renderLastModifiedColumns(

src/applications/diffusion/controller/repository/DiffusionRepositoryController.php

@@ -45,6 +45,9 @@ final class DiffusionRepositoryController extends DiffusionController {
         if ($data->getCommitDetail('authorPHID')) {
           $phids[$data->getCommitDetail('authorPHID')] = true;
         }
+        if ($data->getCommitDetail('committerPHID')) {
+          $phids[$data->getCommitDetail('committerPHID')] = true;
+        }
       }
     }
 
@@ -54,6 +57,9 @@ final class DiffusionRepositoryController extends DiffusionController {
         if ($data->getCommitDetail('authorPHID')) {
           $phids[$data->getCommitDetail('authorPHID')] = true;
         }
+        if ($data->getCommitDetail('committerPHID')) {
+          $phids[$data->getCommitDetail('committerPHID')] = true;
+        }
       }
     }