[Redesign] Add Table, Collapse support to ObjectBox

Summary: Converts most all tables to be directly set via `setTable` to an ObjectBox. I think this path is more flexible design wise, as we can change the box based on children, and not just CSS. We also already do this with PropertyList, Forms, ObjectList, and Header. `setCollapsed` is added to ObjectBox to all children objects to bleed to the edges (like diffs).

Test Plan: I did a grep of `appendChild($table)` as well as searches for `PHUIObjectBoxView`, also with manual opening of hundreds of files. I'm sure I missed 5-8 places. If you just appendChild($table) nothing breaks, it just looks a little funny.

Reviewers: epriestley, btrahan

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12955
This commit is contained in:
Chad Little
2015-05-20 12:43:34 -07:00
parent 667159eb07
commit a4784e03ff
66 changed files with 126 additions and 100 deletions

View File

@@ -57,7 +57,7 @@ final class PhabricatorConfigAllController
$panel = new PHUIObjectBoxView();
$panel->setHeaderText(pht('Current Settings'));
$panel->appendChild($table);
$panel->setTable($table);
$versions = $this->loadVersions();