Clean up Project Members UI

Summary:
 - Better spacing for images
 - Remove border
 - White BG on Members page

Test Plan: Review Projects / Project Home / Project Members

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15118
This commit is contained in:
Chad Little
2016-01-26 21:41:24 +00:00
committed by chad
parent 49a44a0b1f
commit a599aed9e2
4 changed files with 21 additions and 9 deletions

View File

@@ -49,12 +49,14 @@ final class PhabricatorProjectProfileController
->setUser($viewer)
->setProject($project)
->setLimit(5)
->setBackground(PHUIBoxView::GREY)
->setUserPHIDs($project->getMemberPHIDs());
$watcher_list = id(new PhabricatorProjectWatcherListView())
->setUser($viewer)
->setProject($project)
->setLimit(5)
->setBackground(PHUIBoxView::GREY)
->setUserPHIDs($project->getWatcherPHIDs());
$nav = $this->getProfileMenu();

View File

@@ -5,6 +5,7 @@ abstract class PhabricatorProjectUserListView extends AphrontView {
private $project;
private $userPHIDs;
private $limit;
private $background;
public function setProject(PhabricatorProject $project) {
$this->project = $project;
@@ -33,6 +34,11 @@ abstract class PhabricatorProjectUserListView extends AphrontView {
return $this->limit;
}
public function setBackground($color) {
$this->background = $color;
return $this;
}
abstract protected function canEditList();
abstract protected function getNoDataString();
abstract protected function getRemoveURI($phid);
@@ -80,7 +86,7 @@ abstract class PhabricatorProjectUserListView extends AphrontView {
->setImageURI($handle->getImageURI());
$icon = id(new PHUIIconView())
->setIconFont($handle->getIcon().' grey');
->setIconFont($handle->getIcon().' lightbluetext');
$subtitle = $handle->getSubtitle();
@@ -125,10 +131,15 @@ abstract class PhabricatorProjectUserListView extends AphrontView {
->setHref("/project/members/{$id}/"));
}
return id(new PHUIObjectBoxView())
$box = id(new PHUIObjectBoxView())
->setHeader($header)
->setObjectList($list)
->setBackground(PHUIBoxView::GREY);
->setObjectList($list);
if ($this->background) {
$box->setBackground($this->background);
}
return $box;
}
}