archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix errors found by PHPStan

Browse Source 
Test Plan: Ran `phpstan analyze -a autoload.php phabricator/src`.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D17371
This commit is contained in:
Jakub Vrana
2017-02-17 10:10:15 +00:00
committed by vrana
parent b2739710ba
commit a778151f28
80 changed files with 92 additions and 147 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/project/controller/PhabricatorProjectMembersAddController.php
View File

@@ -48,7 +48,7 @@ final class PhabricatorProjectMembersAddController
'+' => array_fuse($member_phids),
));
$editor = id(new PhabricatorProjectTransactionEditor($project))
$editor = id(new PhabricatorProjectTransactionEditor())
->setActor($viewer)
->setContentSourceFromRequest($request)
->setContinueOnNoEffect(true)

2
src/applications/project/controller/PhabricatorProjectMembersRemoveController.php
View File

@@ -49,7 +49,7 @@ final class PhabricatorProjectMembersRemoveController
'-' => array($remove_phid => $remove_phid),
));
$editor = id(new PhabricatorProjectTransactionEditor($project))
$editor = id(new PhabricatorProjectTransactionEditor())
->setActor($viewer)
->setContentSourceFromRequest($request)
->setContinueOnNoEffect(true)

2
src/applications/project/controller/PhabricatorProjectSilenceController.php
View File

@@ -53,7 +53,7 @@ final class PhabricatorProjectSilenceController
$edge_action => array($viewer_phid => $viewer_phid),
));
$editor = id(new PhabricatorProjectTransactionEditor($project))
$editor = id(new PhabricatorProjectTransactionEditor())
->setActor($viewer)
->setContentSourceFromRequest($request)
->setContinueOnNoEffect(true)

2
src/applications/project/controller/PhabricatorProjectUpdateController.php
View File

@@ -67,7 +67,7 @@ final class PhabricatorProjectUpdateController
->setMetadataValue('edge:type', $type_member)
->setNewValue($member_spec);
$editor = id(new PhabricatorProjectTransactionEditor($project))
$editor = id(new PhabricatorProjectTransactionEditor())
->setActor($viewer)
->setContentSourceFromRequest($request)
->setContinueOnNoEffect(true)

2
src/applications/project/controller/PhabricatorProjectWatchController.php
View File

@@ -64,7 +64,7 @@ final class PhabricatorProjectWatchController
->setMetadataValue('edge:type', $type_watcher)
->setNewValue($member_spec);
$editor = id(new PhabricatorProjectTransactionEditor($project))
$editor = id(new PhabricatorProjectTransactionEditor())
->setActor($viewer)
->setContentSourceFromRequest($request)
->setContinueOnNoEffect(true)